Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addChild should not be sensitive to the first letter casing #3436

Closed
gkatsev opened this issue Jul 18, 2016 · 0 comments · Fixed by #3439
Closed

addChild should not be sensitive to the first letter casing #3436

gkatsev opened this issue Jul 18, 2016 · 0 comments · Fixed by #3439
Assignees
@chemoish
Labels
confirmed enhancement

Comments

@gkatsev
Copy link
Member

gkatsev commented Jul 18, 2016

When adding a component using addChild or getting a component using getChild, videojs expects the component to be in a camelCased style. However, the class names are UpperCamelCased which can be a bit confusing to users.
Instead, these methods (and any other related method) should accept the component name as both camelCase and UpperCamelCase but not lowercase or UPPERCASE.

This came up as a result of #3416.
@gkatsev gkatsev mentioned this issue Jul 18, 2016
Closed
6 tasks
@chemoish chemoish mentioned this issue Jul 19, 2016
Merged
6 tasks
@gkatsev gkatsev removed the unclaimed label Jul 19, 2016
gkatsev pushed a commit that referenced this issue Nov 3, 2016
@chemoish @gkatsev
feat: Components are now accessible via camelCase and `UpperCamelCa…
9d77268 
…se` (#3439)

This means that you can `getChild` and `addChild` with both `myComponent` and `MyComponent`.

Fixes #3436.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chemoish chemoish

Labels
confirmed enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Components are now accessible via camelCase and UpperCamelCase me… chemoish/video.js
2 participants
@gkatsev @chemoish