Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitals in tech name cause tech options to go missing #2901

Open
hartman opened this issue Dec 8, 2015 · 0 comments
Open

Capitals in tech name cause tech options to go missing #2901

hartman opened this issue Dec 8, 2015 · 0 comments
Labels
pinned Things that stalebot shouldn't close automatically

Comments

@hartman
Copy link
Contributor

hartman commented Dec 8, 2015

Might be true for other component types as well, but at least for Tech.

If your Tech is named 'OgvJs' or 'HtmL5', than per the camelCase convention of options, you would expect that you can pass Tech options to your Tech like:

{
  ogvJs: {},
  htmL5: {}
}

or

{
  ogvjs: {},
  html5: {}
}

This however doesn't work. The options extra options are not present. If you inspect your Tech inside createEl, then you will see that the instance of your tech there shows this.name_ == null

Instead you have to rename your class to Html5 or Ogvjs, for your options to be copied into the options of the Tech constructor. This is confusing and unexpected.

hartman added a commit to hartman/videojs-ogvjs that referenced this issue Dec 8, 2015
Rename the Tech class from OgvJs to Ogvjs due to videojs/video.js#2901
@gkatsev gkatsev added the pinned Things that stalebot shouldn't close automatically label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Things that stalebot shouldn't close automatically
Projects
None yet
Development

No branches or pull requests

2 participants