-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viash 0.6.1 #250
Viash 0.6.1 #250
Conversation
Markup is in format @[documentation tag](text), only 'text' is displayed on the cli Remove backticks in backtick comments `"example"` becomes "example" on the cli
(missed saving before commit & push)
move Main.readConfigs to Config.readConfigs
…ps are defined (#231).
…ameter. default: `dest = "par"`, but `dest = "meta"` could also be used
Change BashWrapper to accept Longs in minCheckInt & maxCheckInt Keeping the method names as it refers to integer as in zero, natural numbers (1, 2, 3, ...), and negative numbers
Keyword documentation and some other improvements
Feature/generic meta storage
Bugfix/issue 235
`VDSL3`: Fix stub functionality.
* check whether author names are properly escaped * add generic escaper helper * Refactor Bash.escape and Bash.escapeMore to make use of generic escaper * only store author names in docker and nextflow meta info * update changelog * `BashScript`, `CSharpScript`, `JavaScriptScript`, `PythonScript`, `RScript`, `ScalaScript`: Implement more rigorous testing of which characters are escaped. * `BashScript`, `CSharpScript`, `JavaScriptScript`, `PythonScript`, `RScript`, `ScalaScript`: Fix quoting issues of certain characters (#113). * simplify unit test * fix bash executable escaping * fix merge issue
* finish renaming n_proc to cpus * One more * fix changelog (#238)
* `viash test`: Fix issue where `VIASH_TEMP` could not be a relative directory when running `viash test` (#242). * update changelog * fix missing tmpdir * fix info message * remove accidentally committed file * add back loggers
…Removed the 'Version' helper class.
Flexible string fields
Codecov ReportBase: 84.68% // Head: 84.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 84.68% 84.72% +0.04%
==========================================
Files 83 84 +1
Lines 2840 2907 +67
Branches 167 177 +10
==========================================
+ Hits 2405 2463 +58
- Misses 435 444 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This release contains mostly minor improvements of functionality released in Viash 0.6.0. Most notably:
Support was added for
type: long
argumentsmeta["n_proc"]
has been renamed tometa["cpus"]
.meta["cpus"]
is now an integer, whereasmeta["memory_*"]
are now longs.viash ns exec
is able to recognise{platform}
and{namespace}
fields.And various bug fixes and improvements to documentation and unit testing.
BREAKING CHANGES
Deprecated usage
resources_dir
variable inside scripts, usemeta["resources_dir"]
instead (or$meta_resources_dir
in Bash, ormeta$resources_dir
in R).Deprecated
meta["n_proc"]
in favour formeta["cpus"]
.NEW FUNCTIONALITY
viash ns exec
: Added two more fields:{platform}
: the platform name (if applicable){namespace}
: the namespace of the componentLongArgument
: Added support for 64-bit integers withtype: long
as opposed totype: integer
which are 32-bit integers.MAJOR CHANGES
MINOR CHANGES
meta["cpus"]
is now an integer,meta["memory_*"]
are now longs (meta["n_proc"] and meta["memory_*"] are strings #224).DockerPlatform
: Only store author names in the authors metadata.NextflowPlatform
: Only store author names in the authors metadata.Argument[_]
: Turnmultiple_sep
fromChar
intoString
.INTERNAL CHANGES
All
meta[...]
variables are now processed similar toArgument[_]
s, instead of using custom code to convert object types and detect Docker mounts.Escaper
: Make more generic Escaper helper class.DOCUMENTATION
Hardcoded URLs pointing to viash.io in the documentation annotations were replaced with a new keyword system.
Replaced references to "DSL" with "Dynamic Config Modding" in the
--help
output.Added an example for Ruby based Docker setups.
BUG FIXES
viash ns
: Reverse exit code outputs, was returning 1 when everything was OK and 0 when errors were detected (Bugfix/fix exit code #227).viash config inject
: Fix processing of arguments when argument groups are defined (viash config inject doesn't work when argument groups contain required arguments #231).Fixed a few typos in the CLI.
Fixed the formatting of
ns exec
documentation.VDSL3
: Fix stub functionality.VDSL3
: Fix error during error message.viash test
: Fix issue whereVIASH_TEMP
could not be a relative directory when runningviash test
(VIASH_TEMP must be absolute #242).BashScript
,CSharpScript
,JavaScriptScript
,PythonScript
,RScript
,ScalaScript
: Fix quoting issues of certain characters (StringObject escaping bug #113).DEPRECATION
NextflowPlatform
: Deprecate--param_list_format
parameter.TESTING
BashScript
,CSharpScript
,JavaScriptScript
,PythonScript
,RScript
,ScalaScript
: Implement more rigorous testing of which characters are escaped.BashWrapper
: Escape usage ofmultiple_sep
. This fixes various checks and transformations not working when whenmultiple_sep
is set to";"
(Double with multiple: true doesn't seem to work #235).