Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viash 0.6.1 #250

Merged
merged 81 commits into from
Oct 3, 2022
Merged

Viash 0.6.1 #250

merged 81 commits into from
Oct 3, 2022

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Oct 3, 2022

This release contains mostly minor improvements of functionality released in Viash 0.6.0. Most notably:

  • Support was added for type: long arguments

  • meta["n_proc"] has been renamed to meta["cpus"]. meta["cpus"] is now an integer, whereas meta["memory_*"] are now longs.

  • viash ns exec is able to recognise {platform} and {namespace} fields.

  • And various bug fixes and improvements to documentation and unit testing.

BREAKING CHANGES

  • Deprecated usage resources_dir variable inside scripts, use meta["resources_dir"] instead (or $meta_resources_dir in Bash, or meta$resources_dir in R).

  • Deprecated meta["n_proc"] in favour for meta["cpus"].

NEW FUNCTIONALITY

  • viash ns exec: Added two more fields:

    • {platform}: the platform name (if applicable)
    • {namespace}: the namespace of the component
  • LongArgument: Added support for 64-bit integers with type: long as opposed to type: integer which are 32-bit integers.

MAJOR CHANGES

MINOR CHANGES

  • meta["cpus"] is now an integer, meta["memory_*"] are now longs (meta["n_proc"] and meta["memory_*"] are strings #224).

  • DockerPlatform: Only store author names in the authors metadata.

  • NextflowPlatform: Only store author names in the authors metadata.

  • Argument[_]: Turn multiple_sep from Char into String.

INTERNAL CHANGES

  • All meta[...] variables are now processed similar to Argument[_]s, instead of using custom code to convert object types and detect Docker mounts.

  • Escaper: Make more generic Escaper helper class.

DOCUMENTATION

  • Hardcoded URLs pointing to viash.io in the documentation annotations were replaced with a new keyword system.

  • Replaced references to "DSL" with "Dynamic Config Modding" in the --help output.

  • Added an example for Ruby based Docker setups.

BUG FIXES

DEPRECATION

  • NextflowPlatform: Deprecate --param_list_format parameter.

TESTING

  • BashScript, CSharpScript, JavaScriptScript, PythonScript, RScript, ScalaScript: Implement more rigorous testing of which characters are escaped.

  • BashWrapper: Escape usage of multiple_sep. This fixes various checks and transformations not working when when multiple_sep is set to ";" (Double with multiple: true doesn't seem to work #235).

BlackDragonBE and others added 30 commits September 9, 2022 14:13
…g was OK and 0 when errors were detected (#227).

* `viash ns`: Reverse exit code outputs, was returning 1 when everything was OK and 0 when errors were detected (#222).

* fix changelog

* make status a sealed trait instead of an enum
Markup is in format @[documentation tag](text), only 'text' is displayed on the cli
Remove backticks in backtick comments `"example"` becomes "example" on the cli
(missed saving before commit & push)
move Main.readConfigs to Config.readConfigs
…ameter. default: `dest = "par"`, but `dest = "meta"` could also be used
BlackDragonBE and others added 28 commits September 27, 2022 09:25
Change BashWrapper to accept Longs in minCheckInt & maxCheckInt
Keeping the method names as it refers to integer as in zero, natural numbers (1, 2, 3, ...), and negative numbers
Keyword documentation and some other improvements
`VDSL3`: Fix stub functionality.
* check whether author names are properly escaped

* add generic escaper helper

* Refactor Bash.escape and Bash.escapeMore to make use of generic escaper

* only store author names in docker and nextflow meta info

* update changelog

* `BashScript`, `CSharpScript`, `JavaScriptScript`, `PythonScript`, `RScript`, `ScalaScript`: Implement more rigorous testing of which characters are escaped.

* `BashScript`, `CSharpScript`, `JavaScriptScript`, `PythonScript`, `RScript`, `ScalaScript`: Fix quoting issues of certain characters (#113).

* simplify unit test

* fix bash executable escaping

* fix merge issue
* finish renaming n_proc to cpus

* One more

* fix changelog (#238)
* `viash test`: Fix issue where `VIASH_TEMP` could not be a relative directory when running `viash test` (#242).

* update changelog

* fix missing tmpdir

* fix info message

* remove accidentally committed file

* add back loggers
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 84.68% // Head: 84.72% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (9546f59) compared to base (d7e2107).
Patch coverage: 90.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   84.68%   84.72%   +0.04%     
==========================================
  Files          83       84       +1     
  Lines        2840     2907      +67     
  Branches      167      177      +10     
==========================================
+ Hits         2405     2463      +58     
- Misses        435      444       +9     
Impacted Files Coverage Δ
src/main/scala/io/viash/config/package.scala 100.00% <ø> (ø)
...viash/functionality/arguments/DoubleArgument.scala 0.00% <0.00%> (ø)
...o/viash/functionality/arguments/FileArgument.scala 0.00% <0.00%> (ø)
...iash/functionality/arguments/IntegerArgument.scala 0.00% <0.00%> (ø)
...o/viash/functionality/arguments/LongArgument.scala 0.00% <0.00%> (ø)
...main/scala/io/viash/platforms/NativePlatform.scala 90.00% <ø> (ø)
src/main/scala/io/viash/platforms/Platform.scala 83.33% <ø> (ø)
...iash/platforms/requirements/RubyRequirements.scala 0.00% <ø> (ø)
...main/scala/io/viash/schemas/CollectedSchemas.scala 0.00% <0.00%> (ø)
src/main/scala/io/viash/helpers/Helper.scala 94.44% <50.00%> (-4.05%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rcannood rcannood merged commit 4e18fe9 into main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants