-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/relative temp dir #244
Conversation
c8a9943
to
51c5832
Compare
Oops, must have rebased and then forgotten about it. |
Codecov ReportBase: 84.71% // Head: 84.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #244 +/- ##
===========================================
+ Coverage 84.71% 84.75% +0.04%
===========================================
Files 85 85
Lines 2905 2913 +8
Branches 176 172 -4
===========================================
+ Hits 2461 2469 +8
Misses 444 444
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
viash test
: Fix issue whereVIASH_TEMP
could not be a relative directory when runningviash test
(VIASH_TEMP must be absolute #242).Fyi @Grifs, the problem was that if VIASH_TEMP is a relative directory, then running
Process(cmd, cwd = buildDir.toFile)
wherecmd
is a Viash executable will cause all sorts of funny business. The solution was to create a new temporary directory within the temporary directory that's being used for aviash test
, and to provide the new tempdir to the process withProcess(cmd, cwd = buildDir.toFile, "VIASH_TEMP" -> newDir)
.