Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/relative temp dir #244

Merged
merged 12 commits into from
Oct 3, 2022
Merged

Fix/relative temp dir #244

merged 12 commits into from
Oct 3, 2022

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Sep 29, 2022

Fyi @Grifs, the problem was that if VIASH_TEMP is a relative directory, then running Process(cmd, cwd = buildDir.toFile) where cmd is a Viash executable will cause all sorts of funny business. The solution was to create a new temporary directory within the temporary directory that's being used for a viash test, and to provide the new tempdir to the process with Process(cmd, cwd = buildDir.toFile, "VIASH_TEMP" -> newDir).

@rcannood rcannood force-pushed the fix/relative_temp_dir branch from c8a9943 to 51c5832 Compare September 30, 2022 05:20
@rcannood
Copy link
Member Author

rcannood commented Oct 3, 2022

Oops, must have rebased and then forgotten about it.

@rcannood rcannood requested a review from Grifs October 3, 2022 06:51
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 84.71% // Head: 84.75% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (07189f4) compared to base (7d3c1f7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
+ Coverage    84.71%   84.75%   +0.04%     
===========================================
  Files           85       85              
  Lines         2905     2913       +8     
  Branches       176      172       -4     
===========================================
+ Hits          2461     2469       +8     
  Misses         444      444              
Impacted Files Coverage Δ
...main/scala/io/viash/platforms/DockerPlatform.scala 97.10% <ø> (ø)
src/main/scala/io/viash/ViashTest.scala 96.85% <100.00%> (+0.21%) ⬆️
src/main/scala/io/viash/helpers/IO.scala 88.52% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rcannood rcannood merged commit e59ec5d into develop Oct 3, 2022
@rcannood rcannood deleted the fix/relative_temp_dir branch October 5, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant