Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement params #245

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Add requirement params #245

merged 2 commits into from
Oct 2, 2022

Conversation

rcannood
Copy link
Member

First attempt at trying to expose --memory and --cpus params in viash run/test

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 84.56% // Head: 84.71% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (6b6f763) compared to base (17871fa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
+ Coverage    84.56%   84.71%   +0.14%     
===========================================
  Files           85       85              
  Lines         2877     2905      +28     
  Branches       178      176       -2     
===========================================
+ Hits          2433     2461      +28     
  Misses         444      444              
Impacted Files Coverage Δ
src/main/scala/io/viash/ViashNamespace.scala 89.72% <ø> (ø)
src/main/scala/io/viash/Main.scala 71.42% <100.00%> (+2.67%) ⬆️
src/main/scala/io/viash/ViashRun.scala 91.66% <100.00%> (+1.66%) ⬆️
src/main/scala/io/viash/ViashTest.scala 96.63% <100.00%> (+0.21%) ⬆️
src/main/scala/io/viash/cli/CLIConf.scala 97.23% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rcannood rcannood marked this pull request as ready for review October 2, 2022 05:57
@rcannood rcannood merged commit 7d3c1f7 into develop Oct 2, 2022
@rcannood rcannood deleted the feature/add_reqs_params branch October 5, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant