Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 756 fixed the graphd crashed. #760

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

monadbobo
Copy link
Contributor

This time only temporarily avoided this crash,
In issue #192, I will solve this problem for better.

This time only temporarily avoided this crash,
In issue vesoft-inc#192, I will solve this problem for better.
@monadbobo monadbobo added the ready-for-testing PR: ready for the CI test label Aug 13, 2019
@monadbobo
Copy link
Contributor Author

jenkins go!

Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 3fc585f into vesoft-inc:master Aug 13, 2019
@monadbobo
Copy link
Contributor Author

close #589 #756

yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
This time only temporarily avoided this crash,
In issue vesoft-inc#192, I will solve this problem for better.
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
This time only temporarily avoided this crash,
In issue vesoft-inc#192, I will solve this problem for better.
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request May 10, 2022
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [ ] bug
- [ ] feature
- [X] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 

close vesoft-inc#3815 

#### Description:

when releasing a nebula PATCH version(z version of x.y.z), create git tag on one same branch rather than a new branch, such as:

```text
release-3.2   -----+----------+------- branch
                    \          \
                    v3.2.0    v3.2.1   tag
```


## How do you solve it?

use github action manual trigger to package rc version.



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [X] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.)
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:
None

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....
None


Migrated from vesoft-inc#4105

Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants