Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger release workflow manually #4105

Merged
merged 12 commits into from
Mar 31, 2022
Merged

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Mar 31, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #3815

Description:

when releasing a nebula PATCH version(z version of x.y.z), create git tag on one same branch rather than a new branch, such as:

release-3.2   -----+----------+------- branch
                    \          \
                    v3.2.0    v3.2.1   tag

How do you solve it?

use github action manual trigger to package rc version.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

None

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....
None

@yixinglu yixinglu changed the title Update release workflow Trigger release workflow manually Mar 31, 2022
@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Mar 31, 2022
@yixinglu yixinglu requested review from HarrisChu, Aiee and jievince March 31, 2022 06:44
@Sophie-Xie
Copy link
Contributor

Thanks!

And I have some questions, if I enter the version number, is it v3.0.2 or 3.0.2? And Is the name of github tag still v3.0.2?

@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 31, 2022
@yixinglu
Copy link
Contributor Author

Thanks!

And I have some questions, if I enter the version number, is it v3.0.2 or 3.0.2? And Is the name of github tag still v3.0.2?

Input version of the workflow is following format: 3.0.2, there's an example in this parameter description. The tag name should be same as before, such as: v3.0.2.

.gitignore Show resolved Hide resolved
.github/workflows/rc.yml Outdated Show resolved Hide resolved
Aiee
Aiee previously approved these changes Mar 31, 2022
@Shinji-IkariG Shinji-IkariG merged commit 9e7cd06 into vesoft-inc:master Mar 31, 2022
@yixinglu yixinglu deleted the fix-3815 branch March 31, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize branch name and pull method
6 participants