Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize branch name and pull method #3815

Closed
Sophie-Xie opened this issue Jan 26, 2022 · 0 comments · Fixed by #4105
Closed

Optimize branch name and pull method #3815

Sophie-Xie opened this issue Jan 26, 2022 · 0 comments · Fixed by #4105
Assignees
@yixinglu @randomJoe211 @Sophie-Xie
Labels
type/enhancement Type: make the code neat or more efficient
Milestone
v3.1.0

Comments

@Sophie-Xie
Copy link
Contributor

Sophie-Xie commented Jan 26, 2022 •
edited
Loading

  1. The branch name is the same as the tag name now, we should prefix the branch name with "release-". Doc and workflow, etc. also need to be modified.
  2. The vX.Y version should be in a branch, and the bug fix version is identified by tag.
@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Jan 26, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Jan 26, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Jan 29, 2022
Closed
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in Nebula Graph v3.1.0 Feb 19, 2022
@randomJoe211 randomJoe211 self-assigned this Feb 28, 2022
@Sophie-Xie Sophie-Xie moved this from Backlog to Designing in Nebula Graph v3.1.0 Mar 4, 2022
@Sophie-Xie Sophie-Xie moved this from Designing to Coding in Nebula Graph v3.1.0 Mar 9, 2022
@yixinglu yixinglu mentioned this issue Mar 31, 2022
Merged
11 tasks
Repository owner moved this from Coding to Done in Nebula Graph v3.1.0 Mar 31, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Apr 2, 2022
Closed
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this issue May 10, 2022
@nebula-bots @yixinglu
Trigger release workflow manually (vesoft-inc#760)
cfcdbae 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [ ] bug
- [ ] feature
- [X] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 

close vesoft-inc#3815 

#### Description:

when releasing a nebula PATCH version(z version of x.y.z), create git tag on one same branch rather than a new branch, such as:

```text
release-3.2   -----+----------+------- branch
                    \          \
                    v3.2.0    v3.2.1   tag
```


## How do you solve it?

use github action manual trigger to package rc version.



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [X] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:
None

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....
None


Migrated from vesoft-inc#4105

Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yixinglu yixinglu

@randomJoe211 randomJoe211

@Sophie-Xie Sophie-Xie

Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Nebula Graph v3.1.0
Status: Done
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

Trigger release workflow manually yixinglu/nebula
3 participants
@yixinglu @randomJoe211 @Sophie-Xie