Support learner in raft #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangleptr
requested review from
sherman-the-tank and
dutor
and removed request for
sherman-the-tank
|
Jenkins go |
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
whitewum
reviewed
Jun 12, 2019
zlcook
reviewed
Jun 17, 2019
dangleptr
added
do not review
|
It should be based on #552 |
dangleptr
added
ready-for-testing
|
Jenkins go |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing failed. |
|
Unit testing passed. |
wadeliuyi
reviewed
Jul 19, 2019
wadeliuyi
reviewed
Jul 19, 2019
wadeliuyi
reviewed
Jul 19, 2019
wadeliuyi
reviewed
Jul 19, 2019
wadeliuyi
reviewed
Jul 19, 2019
|
Unit testing passed. |
|
Unit testing passed. |
wadeliuyi
reviewed
Jul 23, 2019
| int64_t ts = time::WallClock::fastNowInMilliSec(); | ||
| encoded.append(reinterpret_cast<char*>(&ts), sizeof(int64_t)); | ||
| // Log type | ||
| auto type = LogType::OP_ADD_LEARNER; |
There was a problem hiding this comment.
I think unsigned char is better than auto
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Support Learner in Raft * Remove sleep * Fix failed storage_client_test * Address wadeliuyi's comments
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Reverts vesoft-inc#3548 Need reconsideration. Because the if we add hosts using heartbeat, the zone is not created Migrated from vesoft-inc#3592 Co-authored-by: Doodle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of Support scaling out for storage service. #182