-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support auto registe when storage start up #3548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
reviewed
Dec 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe reuse the old parameter name hosts_whitelist_enabled
panda-sheep
reviewed
Dec 23, 2021
darionyaphet
force-pushed
the
auto-register
branch
from
December 23, 2021 09:15
fced5ab
to
52f9fdd
Compare
jievince
previously approved these changes
Dec 23, 2021
darionyaphet
force-pushed
the
auto-register
branch
2 times, most recently
from
December 23, 2021 09:56
bba5127
to
3af8b80
Compare
Shylock-Hg
approved these changes
Dec 29, 2021
jievince
approved these changes
Dec 29, 2021
critical27
added a commit
that referenced
this pull request
Dec 29, 2021
This reverts commit 6849383.
critical27
added a commit
that referenced
this pull request
Dec 29, 2021
This reverts commit 6849383. Co-authored-by: Yee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: