Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move raftex and wal into kvstore #421

Merged
merged 3 commits into from
Jun 10, 2019
Merged

Conversation

dangleptr
Copy link
Contributor

@dangleptr dangleptr commented May 23, 2019

Just mechanical changes.

subtask of #182

@dangleptr dangleptr requested review from dutor, sherman-the-tank, darionyaphet and laura-ding and removed request for dutor May 23, 2019 05:57
@dangleptr dangleptr added the ready-for-testing PR: ready for the CI test label May 23, 2019
@dangleptr
Copy link
Contributor Author

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@sherman-the-tank
Copy link
Member

Can you hold on this? There are some changes made to raftex and wal, otherwise merge would be very tricky

@nebula-community-bot
Copy link
Member

Unit testing failed.

@dangleptr
Copy link
Contributor Author

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangleptr dangleptr merged commit c4fedff into vesoft-inc:master Jun 10, 2019
@dangleptr dangleptr deleted the refactor branch June 10, 2019 11:11
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
* Move raftex and wal into kvstore

* Rebase on master
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Move raftex and wal into kvstore

* Rebase on master
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants