Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto check keyword #1922

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Auto check keyword #1922

merged 6 commits into from
Mar 30, 2020

Conversation

laura-ding
Copy link
Contributor

@laura-ding laura-ding commented Mar 16, 2020

What changes were proposed in this pull request?

  • If your code adds keywords, it will check the new keyword if in the reserved keyword or the unreserved keyword when you commit the code.
  • If users want to use the reserved keyword, they can use keyword.

Does this PR introduce any user-facing change?

Yes @Amber1990Zhang

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Mar 16, 2020
@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #1922 into master will increase coverage by 0.23%.
The diff coverage is 94.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1922      +/-   ##
==========================================
+ Coverage   86.90%   87.13%   +0.23%     
==========================================
  Files         636      641       +5     
  Lines       59819    60892    +1073     
==========================================
+ Hits        51984    53060    +1076     
+ Misses       7835     7832       -3     
Impacted Files Coverage Δ
src/graph/DescribeSpaceExecutor.h 0.00% <ø> (ø)
src/graph/FetchEdgesExecutor.h 0.00% <ø> (ø)
src/graph/FetchExecutor.cpp 87.77% <ø> (-0.53%) ⬇️
src/graph/FetchVerticesExecutor.h 0.00% <ø> (ø)
src/graph/GoExecutor.h 56.25% <ø> (ø)
src/graph/GraphService.h 100.00% <ø> (ø)
src/graph/PrivilegeExecutor.h 69.56% <ø> (+13.04%) ⬆️
src/graph/SequentialExecutor.h 0.00% <ø> (ø)
src/graph/UseExecutor.h 0.00% <ø> (ø)
src/graph/test/SchemaTest.cpp 96.27% <ø> (-1.07%) ⬇️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f114b21...ac0b324. Read the comment docs.

@jude-zhu jude-zhu requested review from dutor, bright-starry-sky and CPWstatic and removed request for dutor March 16, 2020 02:57
dutor
dutor previously approved these changes Mar 16, 2020
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

src/parser/parser.yy Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

There was an error handling pipeline event cd25976d-2dd6-4683-aad3-12ad21decb9c.

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

src/parser/scanner.lex Show resolved Hide resolved
src/parser/scanner.lex Show resolved Hide resolved
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. LGTM

@dutor dutor merged commit 76e2529 into vesoft-inc:master Mar 30, 2020
dangleptr added a commit that referenced this pull request Apr 1, 2020
* Upgrade rocksdb to 6.7.3 (#1948)

Co-authored-by: heng <[email protected]>
Co-authored-by: yaphet <[email protected]>

* Detect OS type and exit if not built in Linux (#1951)

* Detect OS type and exit if not built in Linux

Signed-off-by: JaySon-Huang <[email protected]>

* Disable for FreeBSD

Signed-off-by: JaySon-Huang <[email protected]>

* [doc] user-permission-mng (#1929)

* alter user & change psw

* built in roles

* cbs comments

* fix comments

* update table

* addenable_authorize doc

* [doc] ttl doc modification (#1939)

* ttl doc modification

* fix comments

* yt comments

* silver days comments

* timestamp update

* Let action not fail fast. (#1909)

* Let action not fail fast.

* Disable the ci will product artifact.

* Remove removePrefix interface in kvstore (#1953)

Co-authored-by: heng <[email protected]>
Co-authored-by: yaphet <[email protected]>

* using admin client in MetaServiceHandler (#1864)

* [doc] fix typo (#1954)

* [doc]show statements (#1924)

* [doc]customized dir (#1906)

* Fixed a bug caused by not filtering the versions of edges (#1962)

* Fixed a bug caused by not filtering the versions of edges when executing "go from vid over *".

* address CPWstatic's comment.

* Modify the listEdges interface and add parameters to directly return all latest versions of edges.

* address laura's comment.

Co-authored-by: dutor <[email protected]>

* [doc]modify job manger doc (#1957)

* modify job manger doc

* add flush

Co-authored-by: dutor <[email protected]>

* Fix delete verticse (#1970)

* Fix the read performance issue after delete range with rocksdb-5.15.10 (#1973)

* Fix the read performace issue after delete range with rocksdb-5.15.10

* Fix the move issue

* fix the move issue

* Rebase and address bright-starry-sky's comments

Co-authored-by: heng <[email protected]>

* Remove the LOG(FATAL) when encounting the unknown log type (#1978)

* 1,Improve customer friendliness; 2, fixed typo error (#1980)

* upgrade spark download address (#1981)

Co-authored-by: dutor <[email protected]>

* fix-typo-in-doc (#1976)

Co-authored-by: dutor <[email protected]>

* modify commands in build doc (#1969)

Co-authored-by: dutor <[email protected]>

* modify log level (#1945)

Co-authored-by: dangleptr <[email protected]>
Co-authored-by: dutor <[email protected]>

* use bloom filter, add event listener to collect stats of compaction, improve update rocksdb options (#1959)

* open bloom filter in default conf, add event listener to collect stats of compaction

* imporve update rocksdb configs

* fix ut error

Co-authored-by: yaphet <[email protected]>

* Update the interface atomicOp to support empty string (#2002)

Co-authored-by: heng <[email protected]>
Co-authored-by: Doodle <[email protected]>

* update to rc4 (#1968)

Co-authored-by: dutor <[email protected]>

* Fixed if you execute "go from xx over *", and when there is no edge under a space, (#1983)

an unreasonable error message is returned (SpaceId `xxx 'is nonexistent)

Co-authored-by: dutor <[email protected]>

* [doc]pr-commit-msg (#1993)

* pr-commit-msg

* add examples

Co-authored-by: dutor <[email protected]>

* doc:modify ttl query (#2006)

Co-authored-by: dutor <[email protected]>

* Let merge coverage report faster by fastcov instead of lcov. (#1943)

Co-authored-by: dutor <[email protected]>

* Auto check keyword (#1922)

* Supports the detection keyword, name_label supports string

* add tests

* address Shylock's comment

* modify  to add reserved keyword

Co-authored-by: dutor <[email protected]>

* Fix coredump for update if encountering bad format row (#2024)

Co-authored-by: heng <[email protected]>
Co-authored-by: bright-starry-sky <[email protected]>

* fixed loop depend problem for compile link (#1995)

* fixed loop depend problem

* fixed error for clang9 and gcc9

* Addressed laura-ding's comment

* Check all reader is null or not before using it (#2029)

* fix go without yield return errror result (#2012)

* fix go without yield return errror result

* fix format

* address dangleptr's comment

* address issue change TTL_DURATION not negative

* add onlyStructure is true test case

Co-authored-by: bright-starry-sky <[email protected]>

* fixed bug for delete vertex without edge (#2001)

* When deleting a vertex, if the edge does not exist,
then we should continue to delete the vertex instead of reporting an error.

* added the testcase for delete vertex without edge.

* add alias for lookup (#2000)

* fix bug 1990/1991 (#2007)

* 1. meta client sub mit job only to leader 2. sort jobs in desc id order

* now show jobs return in desc order, adjust UT

Co-authored-by: dangleptr <[email protected]>

* upload package to oss (#1972)

* upload oss

* update

* Remove redundant

* address @yixinlu's comment

Co-authored-by: dutor <[email protected]>

Co-authored-by: dangleptr <[email protected]>
Co-authored-by: heng <[email protected]>
Co-authored-by: yaphet <[email protected]>
Co-authored-by: JaySon <[email protected]>
Co-authored-by: Amber Zhang <[email protected]>
Co-authored-by: Shylock Hg <[email protected]>
Co-authored-by: Simon Liu <[email protected]>
Co-authored-by: dutor <[email protected]>
Co-authored-by: bright-starry-sky <[email protected]>
Co-authored-by: Liuxue-Yang <[email protected]>
Co-authored-by: laura-ding <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: panda-sheep <[email protected]>
Co-authored-by: liuyu85cn <[email protected]>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Supports the detection keyword, name_label supports string

* add tests

* address Shylock's comment

* modify  to add reserved keyword

Co-authored-by: dutor <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* support storaged-listener script startup

* fix conflict

Co-authored-by: panda-sheep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants