-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the ttl grammar for label the ttl_col , alter grammer. #1874
Conversation
Good job, but I don't feel very friendly to user |
Delete the column is different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ttl_col is the table properpty, I prefer to stay the same or add a new keyword.
such as SET
.
GQLParser parser; | ||
std::string query = "ALTER TAG man ttl_duration = 200"; | ||
std::string query = "ALTER TAG person " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to add the keyword KW_TTL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but drop ttl_col
sounds like drop the schema field.
Such as |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think current changes is good. We could take mysql "alter table" as our reference.
A better way in #1922 |
What changes were proposed in this pull request?
Change the grammar about ttl, not change the inner implement just modify the parser.
such as
from
to
drop from
to
change from
to
Why are the changes needed?
Does this PR introduce any user-facing change?
Yes. @Amber1990Zhang
How was this patch tested?