Using admin client in MetaServiceHandler #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
requested review from
dutor,
CPWstatic,
critical27,
dangleptr,
jude-zhu,
liuyu85cn and
bright-starry-sky
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
+ Coverage 86.90% 87.08% +0.17%
==========================================
Files 636 641 +5
Lines 59819 60891 +1072
==========================================
+ Hits 51984 53025 +1041
- Misses 7835 7866 +31
Continue to review full report at Codecov.
|
|
Why do this? I don't see any improvement if you do that. |
|
Should not create another AdminClient when it already exist |
dangleptr
added a commit
that referenced
this pull request
Apr 1, 2020
* Upgrade rocksdb to 6.7.3 (#1948) Co-authored-by: heng <[email protected]> Co-authored-by: yaphet <[email protected]> * Detect OS type and exit if not built in Linux (#1951) * Detect OS type and exit if not built in Linux Signed-off-by: JaySon-Huang <[email protected]> * Disable for FreeBSD Signed-off-by: JaySon-Huang <[email protected]> * [doc] user-permission-mng (#1929) * alter user & change psw * built in roles * cbs comments * fix comments * update table * addenable_authorize doc * [doc] ttl doc modification (#1939) * ttl doc modification * fix comments * yt comments * silver days comments * timestamp update * Let action not fail fast. (#1909) * Let action not fail fast. * Disable the ci will product artifact. * Remove removePrefix interface in kvstore (#1953) Co-authored-by: heng <[email protected]> Co-authored-by: yaphet <[email protected]> * using admin client in MetaServiceHandler (#1864) * [doc] fix typo (#1954) * [doc]show statements (#1924) * [doc]customized dir (#1906) * Fixed a bug caused by not filtering the versions of edges (#1962) * Fixed a bug caused by not filtering the versions of edges when executing "go from vid over *". * address CPWstatic's comment. * Modify the listEdges interface and add parameters to directly return all latest versions of edges. * address laura's comment. Co-authored-by: dutor <[email protected]> * [doc]modify job manger doc (#1957) * modify job manger doc * add flush Co-authored-by: dutor <[email protected]> * Fix delete verticse (#1970) * Fix the read performance issue after delete range with rocksdb-5.15.10 (#1973) * Fix the read performace issue after delete range with rocksdb-5.15.10 * Fix the move issue * fix the move issue * Rebase and address bright-starry-sky's comments Co-authored-by: heng <[email protected]> * Remove the LOG(FATAL) when encounting the unknown log type (#1978) * 1,Improve customer friendliness; 2, fixed typo error (#1980) * upgrade spark download address (#1981) Co-authored-by: dutor <[email protected]> * fix-typo-in-doc (#1976) Co-authored-by: dutor <[email protected]> * modify commands in build doc (#1969) Co-authored-by: dutor <[email protected]> * modify log level (#1945) Co-authored-by: dangleptr <[email protected]> Co-authored-by: dutor <[email protected]> * use bloom filter, add event listener to collect stats of compaction, improve update rocksdb options (#1959) * open bloom filter in default conf, add event listener to collect stats of compaction * imporve update rocksdb configs * fix ut error Co-authored-by: yaphet <[email protected]> * Update the interface atomicOp to support empty string (#2002) Co-authored-by: heng <[email protected]> Co-authored-by: Doodle <[email protected]> * update to rc4 (#1968) Co-authored-by: dutor <[email protected]> * Fixed if you execute "go from xx over *", and when there is no edge under a space, (#1983) an unreasonable error message is returned (SpaceId `xxx 'is nonexistent) Co-authored-by: dutor <[email protected]> * [doc]pr-commit-msg (#1993) * pr-commit-msg * add examples Co-authored-by: dutor <[email protected]> * doc:modify ttl query (#2006) Co-authored-by: dutor <[email protected]> * Let merge coverage report faster by fastcov instead of lcov. (#1943) Co-authored-by: dutor <[email protected]> * Auto check keyword (#1922) * Supports the detection keyword, name_label supports string * add tests * address Shylock's comment * modify to add reserved keyword Co-authored-by: dutor <[email protected]> * Fix coredump for update if encountering bad format row (#2024) Co-authored-by: heng <[email protected]> Co-authored-by: bright-starry-sky <[email protected]> * fixed loop depend problem for compile link (#1995) * fixed loop depend problem * fixed error for clang9 and gcc9 * Addressed laura-ding's comment * Check all reader is null or not before using it (#2029) * fix go without yield return errror result (#2012) * fix go without yield return errror result * fix format * address dangleptr's comment * address issue change TTL_DURATION not negative * add onlyStructure is true test case Co-authored-by: bright-starry-sky <[email protected]> * fixed bug for delete vertex without edge (#2001) * When deleting a vertex, if the edge does not exist, then we should continue to delete the vertex instead of reporting an error. * added the testcase for delete vertex without edge. * add alias for lookup (#2000) * fix bug 1990/1991 (#2007) * 1. meta client sub mit job only to leader 2. sort jobs in desc id order * now show jobs return in desc order, adjust UT Co-authored-by: dangleptr <[email protected]> * upload package to oss (#1972) * upload oss * update * Remove redundant * address @yixinlu's comment Co-authored-by: dutor <[email protected]> Co-authored-by: dangleptr <[email protected]> Co-authored-by: heng <[email protected]> Co-authored-by: yaphet <[email protected]> Co-authored-by: JaySon <[email protected]> Co-authored-by: Amber Zhang <[email protected]> Co-authored-by: Shylock Hg <[email protected]> Co-authored-by: Simon Liu <[email protected]> Co-authored-by: dutor <[email protected]> Co-authored-by: bright-starry-sky <[email protected]> Co-authored-by: Liuxue-Yang <[email protected]> Co-authored-by: laura-ding <[email protected]> Co-authored-by: Doodle <[email protected]> Co-authored-by: panda-sheep <[email protected]> Co-authored-by: liuyu85cn <[email protected]>
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* Fix wrong invoke of toEdgeName * resolve the conflicts Co-authored-by: jie.wang <[email protected]> Co-authored-by: Yee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.