Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: alt.themes -> alt.theme #3618

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

refactor: alt.themes -> alt.theme #3618

wants to merge 66 commits into from

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Sep 28, 2024

Need a way to make sense of these and start GH threads:

- 10 total files
- 3 modules named `theme.py`
- 2 modules named `__init__.py`
@dangotbanned dangotbanned added maintenance deprecation Requires a **MINOR** version bump labels Sep 28, 2024
altair/__init__.py Outdated Show resolved Hide resolved
altair/theme.py Outdated Show resolved Hide resolved
@dangotbanned
Copy link
Member Author

@mattijn I've addressed (#3618 (comment)) in (a0497e0)

All of the Unresolved conversations are just to help make the review easier.
You can dismiss once you've seen them to unblock merging

Copy link
Contributor

@mattijn mattijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I approve. However, I’d like another maintainer to review this as well due to the significant impact of this PR. Once merged, it will require updates to several published packages on PyPI, such as those listed here: https://pypi.org/search/?q=altair+theme.

@dangotbanned
Copy link
Member Author

Thanks, I approve. However, I’d like another maintainer to review this as well due to the significant impact of this PR. Once merged, it will require updates to several published packages on PyPI, such as those listed here: pypi.org/search?q=altair+theme.

Thanks for the review @mattijn!

Yeah that makes sense, always good to have another set of eyes

@dangotbanned dangotbanned mentioned this pull request Oct 25, 2024
4 tasks
@dangotbanned
Copy link
Member Author

Thanks, I approve. However, I’d like another maintainer to review this as well due to the significant impact of this PR. Once merged, it will require updates to several published packages on PyPI, such as those listed here: pypi.org/search?q=altair+theme.

@mattijn @jonmmease

Apologies if this was already clear, but I just wanted to restate it in a short format for some reassurance.


  • Merging this PR will require no changes to dependent packages using the public API of altair until at least 6.0.0.
  • Using alt.themes in >=5.5.0; <6.0.0 will display a warning on first use only
  • Static typing users (who have opted-in to this kind of reporting) will see warnings displayed on every use of alt.themes.register

@dangotbanned
Copy link
Member Author

Caught that one quite late 😅 (#3618 (comment))

@mattijn
Copy link
Contributor

mattijn commented Nov 4, 2024

Any opinion on this @joelostblom, @jonmmease? I'm not a themes/theme user myself, so it is hard for me to overview the impact. Do we know anyone who is/are using the theme and will be impacted by this?

@mattijn
Copy link
Contributor

mattijn commented Nov 4, 2024

Or, put positively, someone who could benefit from this PR and might be able to provide a quick check. Otherwise I will press the merge button in a week, November 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Requires a **MINOR** version bump maintenance
Projects
None yet
2 participants