Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Drop support for Python 3.8 #3647

Merged
merged 5 commits into from
Oct 21, 2024
Merged

ci: Drop support for Python 3.8 #3647

merged 5 commits into from
Oct 21, 2024

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Oct 21, 2024

Closes #3497

Note for reviewers

Most of the changes in this PR were handled by ruff, and relate to these 3.9 changes:

Essentially, this looks like a big job but excluding (c765897) this is actually quite a minor PR

Tasks

These should be the first supported versions our min python
@dangotbanned dangotbanned self-assigned this Oct 21, 2024
@dangotbanned
Copy link
Member Author

dangotbanned commented Oct 21, 2024

The CI error is a bit cryptic, but I think #3494 was due to similar error

@MarcoGorelli if you're available, I just wanted to run this by you in case you can spot the issue in

https://github.com/vega/altair/actions/runs/11438192791/job/31819284620?pr=3647

I think it is this line, but quite unsure why this has become an issue here

ibis.set_backend("polars")

Update

Fixed in test: Try invoking ibis.set_backend only in scopes that use it

@dangotbanned dangotbanned marked this pull request as ready for review October 21, 2024 12:00
@dangotbanned
Copy link
Member Author

Not sure how to unblock the expected checks for:

  • py 3.8 js 3.0
  • py 3.8 js latest

They were removed in da300c3 (#3647)

@dangotbanned
Copy link
Member Author

dangotbanned commented Oct 21, 2024

#3647 (comment)
It seems this was baked into the branch protection rules in #3562 (comment)

Screenshot from that PR (@binste)

image

I still don't have the permissions for viewing/editing these rules - so I'll need some help updating them if anyone is available?

@mattijn @jonmmease @joelostblom

@mattijn
Copy link
Contributor

mattijn commented Oct 21, 2024

I've removed the rules in the rule set for Python version 3.8. All checks are now green, is that in line what is expected? I did not look careful if the CI in this PR was still red before I made the change to the ruleset.

@dangotbanned
Copy link
Member Author

dangotbanned commented Oct 21, 2024

I've removed the rules in the rule set for Python version 3.8. All checks are now green, is that in line what is expected? I did not look careful if the CI in this PR was still red before I made the change to the ruleset.

Thanks @mattijn

It was all green except, with the two 3.8 jobs mentioned in #3647 (comment) marked as expected (but neither pass/failing)
No reds since 5995202 (#3647)

@mattijn
Copy link
Contributor

mattijn commented Oct 21, 2024

Is pandas version 1.1.3 the minimum supported version for Python 3.9?

@dangotbanned
Copy link
Member Author

Is pandas version 1.1.3 the minimum supported version for Python 3.9?

That was the earliest I found going through the release notes @mattijn

I think numpy had some level of support before 1.19.3, but it looked like more of an announcement in that version

@mattijn mattijn merged commit 2ba89d5 into main Oct 21, 2024
23 checks passed
@mattijn
Copy link
Contributor

mattijn commented Oct 21, 2024

Thanks! Moving forward🥳

@dangotbanned dangotbanned deleted the drop-py38-support branch October 21, 2024 21:03
@dangotbanned dangotbanned mentioned this pull request Nov 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing for Python 3.8 EOL
2 participants