-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Support Python 3.13 #3591
ci: Support Python 3.13 #3591
Conversation
Minimal/fallback support for `3.13`. Ideally I'd like to minimise hard dependencies we have on `typing_extensions` before October 2024. However, this would be the simpler option if it passes CI Resolves #3587
I think it is noble to wait for support for python 3.13 for all our upstream soft dependencies. But I'm also not against releasing before all our soft dependencies provide support (in my understanding pyarrow). What you think @dangotbanned? |
@mattijn nothing noble here 😄 I'm happy with releasing before Also maybe do some decoupling in Doing either of those is fine with me if you'd like to give it a try? Personally though, I've got a few issues/PRs that I'd rather have ready for
I think there's more value in delivering some/all of these vs a slightly earlier |
Hmpf. Decoupling |
No worries @mattijn Also, IIRC |
Yeah, I assume that geospatial users of Altair are the minority, so if that's causing the delay, also feel a bit responsible for that. |
Its not on you @mattijn! |
Basising this off of narwhals-dev/narwhals@97ebe2c
Seems to be able to build (sometimes) with these changes. Still fails a good chunk of the tests
I'm all out of ideas on this one 😞 @mattijn @jonmmease @joelostblom @binste |
It looks like pip is first installing pyarrow 18, but then installs 17, which it tries to build from source since there aren't wheel published for Python 3.13. I think the issue is that ibis 9.5.0 has an upper bound on pyarrow of I don't recall offhand which of our tests need ibis with the polars backend, but we could see if theres a way to rework them without it. |
Thanks @jonmmease
If that is the issue, these tests are the one's that need it: altair/tests/vegalite/v5/test_api.py Lines 1614 to 1656 in 211f7c5
I had to change those a bit when dropping Interesting if they cause problems in both cases |
@MarcoGorelli I'd been following the |
hey - I'd suggest removing Ibis from CI, I think we can use duckdb for that test, I'll make a PR here you go #3672 (note that we continue to test Ibis in CI in Narwhals, so support for it should stay strong) |
@MarcoGorelli looks to have done the job, thanks again 🙏 |
Indeed thanks @MarcoGorelli! Appreciated👍 |
Resolves #3587
Minimal/fallback support for
3.13
.Ideally I'd like to minimise hard dependencies we have on
typing_extensions
before October 2024. However, this would be the simpler option if it passes CI