Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix easy ESLint Errors #169

Merged
merged 19 commits into from
Sep 12, 2022
Merged

Fix easy ESLint Errors #169

merged 19 commits into from
Sep 12, 2022

Conversation

vatro
Copy link
Owner

@vatro vatro commented Sep 12, 2022

closes #164
closes #166

No ESLint Errors in components left, only no-explicit-any + two no-unused-vars warnings.

Currently 5 Errors in project left (related to #165)
ESLint: ✖ 413 problems (5 errors, 408 warnings) (no-explicit-any + two no-unused-vars warnings)

...\lib\ani\SvelthreeAnimationManager.ts
  7:38  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any    
 13:50  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
171:18  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

...\lib\types\types-extra.ts
 85:22  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
117:8   error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

svelte-check: svelte-check found 0 errors, 0 warnings, and 0 hints

Vatroslav Vrbanic added 19 commits September 12, 2022 13:52
package.json Add lint : quiet script
71db65e 
to show Errors only.
.vscode\settings.json Fix ESLInt VS Code highlighting (#164)
cc549ac
Fix easy ESLint Errors (not components) (#164)
3382512
Delete unused utils\PropUtilsComplex.ts (#164)
091416d 
outdated / unfinished / unused
utils\GLTF_utils.ts fix ESLint no-inner-declarations (#164)
51cab8a
utils\GLTF_afterLoaded.ts fix ESLint no-inner-declarations (#164)
f5f8e43
utils\Calc.ts fix ESLint no-empty-constructor
2d15b30
types-extra.ts Remove unused type Params<T>
2cd224d 
outdated / unused
types-extra.ts Add TODO for SvelthreeAnimation related types (#165)
95fb2a6
ani\SvelthreeAnimationProp.ts fix ESLint no-prototype-builtins (#164
5d42040 
)
ani\SvelthreeAnimationManager.ts Add TODO for SvelthreeAnimation re…
c9fe561 
…lated types (#165)
.eslintrc.cjs ESLint components Errors check configuration (#166)
26f27c0
*.svelte fix ESLint no-inferrable-types (#166)
4531f5b
SvelthreeInteraction fix ESLint no-undef (#166)
5abd6ac
*.svelte ignore ESLint no-undef on ARIAMixin interface (#166)
43576b0 
`svelte-check` and the generated `package` / `d.ts` are OK with it, so just ignoring it (for now).
I don't know why ESLint marks this as Error (atm).
SvelthreeInteraction fix ESLint no-empty (#166)
ff8de66 
quick'n'dirty (for now) see #167
Points change on_instance_provided() logic (same as Mesh), closes
e11bc02 
#168

noticed while fixing ESLint `no-empty` (#166)
SvelthreeInteraction fix ESLint no-case-declarations (#166)
f3e87a1
CubeCamera fix ESLint no-prototype-builtins (#166)
4344a39
@vatro vatro added this to the 1.0.0-next.1 milestone Sep 12, 2022
@vatro vatro self-assigned this Sep 12, 2022
@vatro vatro merged commit 8af2649 into dev Sep 12, 2022
@vatro vatro deleted the major-eslint-aided-polish branch September 12, 2022 15:51
@vatro vatro mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vatro vatro

Labels
code quality easy Errors ESLint
Projects
None yet
Milestone
1.0.0-next.1
Development

Successfully merging this pull request may close these issues.

Fix easy ESLint Errors (components) Fix easy ESLint Errors (not components)
1 participant
@vatro