Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix easy ESLint Errors (components) #166

Closed
vatro opened this issue Sep 12, 2022 · 0 comments · Fixed by #169
Closed

Fix easy ESLint Errors (components) #166

vatro opened this issue Sep 12, 2022 · 0 comments · Fixed by #169
Assignees
@vatro
Labels
code quality easy Errors ESLint
Milestone
1.0.0-next.1

Comments

@vatro
Copy link
Owner

vatro commented Sep 12, 2022

Fix all easy ESLint Errors in *.svelte` files.
@vatro vatro added this to the 1.0.0-next.1 milestone Sep 12, 2022
@vatro vatro self-assigned this Sep 12, 2022
vatro pushed a commit that referenced this issue Sep 12, 2022
.eslintrc.cjs ESLint components Errors check configuration (#166)
26f27c0
vatro pushed a commit that referenced this issue Sep 12, 2022
*.svelte fix ESLint no-inferrable-types (#166)
4531f5b
vatro pushed a commit that referenced this issue Sep 12, 2022
SvelthreeInteraction fix ESLint no-undef (#166)
5abd6ac
vatro pushed a commit that referenced this issue Sep 12, 2022
*.svelte ignore ESLint no-undef on ARIAMixin interface (#166)
43576b0 
`svelte-check` and the generated `package` / `d.ts` are OK with it, so just ignoring it (for now).
I don't know why ESLint marks this as Error (atm).
vatro pushed a commit that referenced this issue Sep 12, 2022
SvelthreeInteraction fix ESLint no-empty (#166)
ff8de66 
quick'n'dirty (for now) see #167
vatro pushed a commit that referenced this issue Sep 12, 2022
Points change on_instance_provided() logic (same as Mesh), closes
e11bc02 
#168

noticed while fixing ESLint `no-empty` (#166)
vatro pushed a commit that referenced this issue Sep 12, 2022
SvelthreeInteraction fix ESLint no-case-declarations (#166)
f3e87a1
vatro pushed a commit that referenced this issue Sep 12, 2022
CubeCamera fix ESLint no-prototype-builtins (#166)
4344a39
@vatro vatro mentioned this issue Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vatro vatro

Labels
code quality easy Errors ESLint
Projects
None yet
Milestone
1.0.0-next.1
Development

Successfully merging a pull request may close this issue.

Fix easy ESLint Errors vatro/svelthree
1 participant
@vatro