Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components generator (not public) change logic for on_instance_provided() generation #167

Closed
vatro opened this issue Sep 12, 2022 · 0 comments
Assignees
Milestone

Comments

@vatro
Copy link
Owner

vatro commented Sep 12, 2022

should be

if (inst.type !== "Foo") {
  throw new Error(...)
}

instead of

if (inst.type === "Foo") {
  //nothing
} else {
  throw new Error(...)
}

for specific components.

@vatro vatro added this to the 1.0.0-next.X milestone Sep 12, 2022
@vatro vatro self-assigned this Sep 12, 2022
vatro pushed a commit that referenced this issue Sep 12, 2022
quick'n'dirty (for now) see #167
@vatro vatro closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant