Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDS refresh improved controls #12896

Conversation

riverwanderer
Copy link
Collaborator

@riverwanderer riverwanderer commented Nov 10, 2023

Expanded "orphan counter" functionality - reporting / ability to repair (sub-option).
New filter field and associated functionality for PDS Refresh.
Other UI improvements.

New options & sub-options shown. Actual defaults are unchanged from vassal v3.7.5:
image

Addresses an outstanding part of #11999.

Other PDS Refresh improvements:
Control panel re-organised and window title upgraded to a Progress bar.
Removed faulty "test" option & non-functioning "delete when no map" option.
Alert option for end of refresh run (using default Vassal system wake-up sound).
Avoids duplicate file entries.
Error / warnings summary collated and reported at end of run.
Sets the GameModule dirty flag if a refresh is done.

Improvements to standard Refresh Counters:
Each of the warning messages is only issued (now highlighted in red) if 1 or instances of the error/anomaly are detected.
Control panel updated for consistency with PDS Refresh.

riverwanderer and others added 9 commits November 9, 2023 13:09
…rmat (deck) sub-options. Make delete no map pieces default (consistent with Refresh Counters). Rationalise option settings & use constants always. Doc spelling & grammar tweaks.
…f PDS to be processed). For module development.
…nd technical stats. Tidy up the control panels.
…nd technical stats. Tidy up the control panels.
riverwanderer and others added 19 commits November 12, 2023 22:48
…nto PDS-refresh-improved-controls

# Conflicts:
#	vassal-app/src/main/java/VASSAL/configure/RefreshPredefinedSetupsDialog.java
#	vassal-app/src/main/resources/VASSAL/i18n/Editor.properties
…efresh of both pieces and decks will be of more use once Hotkeys feature is added. Piece refresh is still the default.
…efresh of both pieces and decks will be of more use once Hotkeys feature is added. Piece refresh is still the default. Removed a redundant array (decks) from GameRefresher which was populated during the Pieces refresh.
@riverwanderer
Copy link
Collaborator Author

Closing in favour of #12898 which contains the same features and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant