-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDS refresh improved controls #12896
Closed
riverwanderer
wants to merge
45
commits into
vassalengine:master
from
riverwanderer:PDS-refresh-improved-controls
Closed
PDS refresh improved controls #12896
riverwanderer
wants to merge
45
commits into
vassalengine:master
from
riverwanderer:PDS-refresh-improved-controls
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat (deck) sub-options. Make delete no map pieces default (consistent with Refresh Counters). Rationalise option settings & use constants always. Doc spelling & grammar tweaks.
…f PDS to be processed). For module development.
…o PDS-devtest-sampling-option
… Pattern null proteciton.
…nd technical stats. Tidy up the control panels.
…nd technical stats. Tidy up the control panels.
This was referenced Nov 10, 2023
…ror status in window bar.
…ror status in window bar.
…K' into PDS-refresh-improved-controls-GHK # Conflicts: # vassal-app/src/main/java/VASSAL/configure/RefreshPredefinedSetupsDialog.java # vassal-app/src/main/resources/VASSAL/i18n/Editor.properties
…nto PDS-refresh-improved-controls
…e (perhaps temporarily) a couple of features.
…l window (super) modal setting.
…nto PDS-refresh-improved-controls # Conflicts: # vassal-app/src/main/java/VASSAL/configure/RefreshPredefinedSetupsDialog.java # vassal-app/src/main/resources/VASSAL/i18n/Editor.properties
…preventing game load.
…preventing game load.
…efresh of both pieces and decks will be of more use once Hotkeys feature is added. Piece refresh is still the default.
…efresh of both pieces and decks will be of more use once Hotkeys feature is added. Piece refresh is still the default. Removed a redundant array (decks) from GameRefresher which was populated during the Pieces refresh.
This was
linked to
issues
Nov 19, 2023
Closing in favour of #12898 which contains the same features and more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded "orphan counter" functionality - reporting / ability to repair (sub-option).
New filter field and associated functionality for PDS Refresh.
Other UI improvements.
New options & sub-options shown. Actual defaults are unchanged from vassal v3.7.5:
Addresses an outstanding part of #11999.
Other PDS Refresh improvements:
Control panel re-organised and window title upgraded to a Progress bar.
Removed faulty "test" option & non-functioning "delete when no map" option.
Alert option for end of refresh run (using default Vassal system wake-up sound).
Avoids duplicate file entries.
Error / warnings summary collated and reported at end of run.
Sets the GameModule dirty flag if a refresh is done.
Improvements to standard Refresh Counters:
Each of the warning messages is only issued (now highlighted in red) if 1 or instances of the error/anomaly are detected.
Control panel updated for consistency with PDS Refresh.