Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refresher]Improve support for Counters not matching #12914

Closed
riverwanderer opened this issue Nov 18, 2023 · 0 comments · Fixed by #12898
Closed

[Refresher]Improve support for Counters not matching #12914

riverwanderer opened this issue Nov 18, 2023 · 0 comments · Fixed by #12898
Assignees
@riverwanderer
Labels
enhancement New feature or request

Comments

@riverwanderer
Copy link
Collaborator

The GameRefresher provides no information to highlight counters that fail to match on a GpId. This can led to unexpected issues due to unnoticed refresh failures, especially as "Use Counter names..." is off by default.
image

I propose to introduce messaging in GpIdChecker createUpdatedPiece() to advise when that option should be tried.

@BrentEaston - is there a downside to making the use names option ON by default ?
Also, how about a new option to entirely replace the old piece with the matching one? Any advice on that idea?
@riverwanderer riverwanderer added the enhancement New feature or request label Nov 18, 2023
@riverwanderer riverwanderer self-assigned this Nov 18, 2023
@riverwanderer riverwanderer linked a pull request Nov 19, 2023 that will close this issue
PDS refresh improved controls #12896
Closed
@riverwanderer riverwanderer linked a pull request Dec 1, 2023 that will close this issue
PDS refresh improved controls with GHK feature #12898
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riverwanderer riverwanderer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@riverwanderer