PDS refresh improved controls with GHK feature #12898
Conversation
… 12260-refreshPre&PostwithControls
… 12260-refreshPre&PostwithControls
…s' into 12260-refreshPre&PostwithControls
… 12260-refreshPre&PostwithControls
…fresh is opt-in, PDS referesh is opt-out. Deck refresh options are formatted to distinguish them from main options.
…stPreControls2 # Conflicts: # vassal-app/src/main/java/VASSAL/build/module/GameRefresher.java # vassal-doc/src/main/readme-referencemanual/ReferenceManual/GameRefresher.adoc
…verwanderer/vassal into 12260-refreshPostPreControls2 # Conflicts: # vassal-doc/src/main/readme-referencemanual/ReferenceManual/GameRefresher.adoc
… Rationalise option settings. Attempt to close (dispose) options window at the end of processing.
…rmat (deck) sub-options. Make delete no map pieces default (consistent with Refresh Counters). Rationalise option settings & use constants always. Doc spelling & grammar tweaks.
…ssal into 12260-refreshPostPreControls2 # Conflicts: # vassal-app/src/main/java/VASSAL/build/module/GameRefresher.java # vassal-doc/src/main/readme-referencemanual/ReferenceManual/GameRefresher.adoc
…f PDS to be processed). For module development.
…o PDS-devtest-sampling-option
… Pattern null proteciton.
riverwanderer
added
Ready for Review
vassal-app/src/main/java/VASSAL/configure/RefreshPredefinedSetupsDialog.java
Outdated
Show resolved
Hide resolved
… PDS-refresh-improved-controls-GHK
… PDS-refresh-improved-controls-GHK
…x to GpidChecker.noGpIdMatch is appropriate and that the related declarations in GameRefresher are also ok (lines 118-124).
|
Hello Mark, |
Thanks @claudiociardelli - I have had great benefit from that work over those years! More recently, since I've started to dip my toe into Java and Vassal itself, through this PR I've added mainly peripheral features that I thought would be useful to make PDS-related workflow even more efficient. In the core refresh, apart from an optional, non-default ability to "repair" orphan pieces (no matching GPiD), I've only tweaked the reporting output. I'd like to add ability to populate decks and at-start stacks but time to explore that eludes me at the moment. |
| int noMapCount; // shared to PDS refresher - not used!!! | ||
| int notOwnedCount; // shared to PDS refresher | ||
| int notVisibleCount; // shared to PDS refresher | ||
| int deckWarnings; // shared to PDS refresher |
There was a problem hiding this comment.
What's the deal with these? They need a visibility modifier. Should they be private? protected?
There was a problem hiding this comment.
These variables and the 3 immediately preceding them are various types of error accumulated during a refresh run. Visibility must at least allow PreDefinedSetup.java to access them - it uses them to return an error count to RefreshPreDefinedSetupDialog. This is all so that the user gets a summary at the end rather than having to trawl through all the refresh logs.
Private doesn't work so I guess Protected ? IntelliJ doesn't approve of that and warns "Class member declared 'protected' in 'final' class" hence I accepted it's suggestion, which removed the Protected modifier:
i can added the Protected modifiers back in unless there's some other way I should be doing this.
There was a problem hiding this comment.
All see that you're doing with these variables outside of GameRefresher is summing them in one location. If that's all you need, then they should be made private and you can create a public method inside of which you compute the sum, and then call that method from outside of GameRefresher.
There was a problem hiding this comment.
Thanks. I've pushed the fix to this.
Whilst doing the fix, I've noticed that somehow in a commit on 7th Dec, I've managed to over-write the change history in GameRefresher. I presume it's happened whilst I was working around a glitch in IntelliJ. I think I may need to unwind or re-do this PR to fix this.
Expanded "orphan counter" functionality - reporting / ability to repair (sub-option).
Ability to do additional processing via a special post-refresh Global Hotkey, optionally without routine refresh reporting.
New filter field and associated functionality for PDS Refresh.
Other UI improvements.
New options & sub-options shown. Actual defaults are unchanged from vassal v3.7.5:
Addresses an outstanding part of #11999.
Other PDS Refresh improvements:
Control panel re-organised and window title upgraded to a Progress bar.
Removed faulty "test" option & non-functioning "delete when no map" option.
Alert option for end of refresh run (using default Vassal system wake-up sound).
Avoids duplicate file entries.
Error / warnings summary collated and reported at end of run.
Sets the GameModule dirty flag if a refresh is done.
Improvements to standard Refresh Counters:
Each of the warning messages is only issued (now highlighted in red) if 1 or instances of the error/anomaly are detected.
Control panel updated for consistency with PDS Refresh.