DNS validation #19
Closed
DNS validation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
force-pushed
the
dns-validation
branch
2 times, most recently
from
48acfdc
to
6b5b01d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
===========================================
- Coverage 62.85% 46.30% -16.56%
===========================================
Files 2 2
Lines 140 203 +63
===========================================
+ Hits 88 94 +6
- Misses 49 102 +53
- Partials 3 7 +4
Continue to review full report in Codecov by Sentry.
|
This was referenced Feb 15, 2024
oz123
force-pushed
the
dns-validation
branch
4 times, most recently
from
f51e94e
to
e5c5cb6
Compare
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Update the method for returning DNSServers. Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Instead of string - define a Nameserver type without any fields. Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
Signed-off-by: Oz Tiram <[email protected]>
oz123
force-pushed
the
dns-validation
branch
from
a40890d
to
83c3109
Compare
Signed-off-by: Oz Tiram <[email protected]>
Previouly, the client failed to initialize because the token was not in the correct format.
oz123
force-pushed
the
dns-validation
branch
from
83c3109
to
9d65fd1
Compare
Validation now looks that DNS servers are available and working. Since the types were changes, and the logic too, I temporarily disabled the tests. Signed-off-by: Oz Tiram <[email protected]>
While this is just a simple test, it can be used for the intgration tests. Signed-off-by: Oz Tiram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting up to speed here after a slow start ...