Properly initialize the client with a secret

Previouly, the client failed to initialize because the token was
not in the correct format.

internal/controller/maasvalidator_controller.go

@@ -18,6 +18,7 @@ package controller
 
 import (
 	"context"
+	"encoding/base64"
 	"fmt"
 	"strings"
 	"time"
@@ -161,7 +162,11 @@ func (r *MaasValidatorReconciler) tokenFromSecret(name, namespace string) (strin
 	if key, found := secret.Data["MAAS_API_KEY"]; found {
 		token := string(key)
 		token = strings.TrimSuffix(token, "\n")
-		return token, nil
+		decodedBytes, err := base64.StdEncoding.DecodeString(token)
+		if err != nil {
+			return "", fmt.Errorf("failed to decode secret data")
+		}
+		return string(decodedBytes), nil
 	}
 	return "", fmt.Errorf("secret does not contain MAAS_API_KEY")
 }

internal/controller/maasvalidator_controller_test.go

@@ -47,8 +47,6 @@ var _ = Describe("MaaSValidator controller", Ordered, func() {
 		},
 	}
 
-	//secret := &corev1.Secret{}
-
 	vr := &vapi.ValidationResult{}
 	vrKey := types.NamespacedName{Name: validationResultName(val), Namespace: validatorNamespace}
 

internal/controller/suite_test.go

@@ -141,6 +141,21 @@ var _ = BeforeSuite(func() {
 	}).SetupWithManager(k8sManager)
 	Expect(err).ToNot(HaveOccurred(), "failed to start MaasValidator controller")
 
+	secret := &corev1.Secret{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "maas-api-token",
+			Namespace: validatorNamespace,
+		},
+		StringData: map[string]string{
+			// there is no such token, this is just a dummy
+			"MAAS_API_KEY": "LEV2Ulo4THd1eGtVMjJ4dkRjOmpXeXRqS2d5ZFlOVTlxdmZEaDo2VmFzTEhKU3hVaFBOeDdTNVd3N1ZzdVNQakJGc2FVUQo=", //gitleaks:allow
+		},
+		Type: corev1.SecretTypeOpaque,
+	}
+
+	err = k8sClient.Create(ctx, secret)
+	Expect(err).ToNot(HaveOccurred(), "failed to create maas secret")
+
 	go func() {
 		defer GinkgoRecover()
 		err = k8sManager.Start(ctx)