Stricter type validation for Nameserver

Instead of string - define a Nameserver type without any fields. Signed-off-by: Oz Tiram <[email protected]>
validator-labs · Feb 15, 2024 · 48acfdc · 48acfdc
1 parent 26a1e6d
commit 48acfdc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/api/v1alpha1/maasvalidator_types.go b/api/v1alpha1/maasvalidator_types.go
@@ -38,13 +38,15 @@ type MaasInstance struct {
 	Auth Auth `json:"auth" yaml:"auth"`
 }
 
+type Nameserver string
+
 type MaasInstanceRules struct {
 	// Unique rule name
 	Name string `json:"name" yaml:"name"`
 	// OSImages is a list of bootable os images
 	OSImages []OSImage `json:"bootable-images,omitempty" yaml:"bootable-images,omitempty"`
 	// List of DNS Servers (IP addresses)
-	Nameservers []string `json:"nameservers,omitempty" yaml:"nameservers,omitempty"`
+	Nameservers []Nameserver `json:"nameservers,omitempty" yaml:"nameservers,omitempty"`
 }
 
 type OSImage struct {

diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
diff --git a/internal/validators/maas_validator.go b/internal/validators/maas_validator.go
@@ -57,7 +57,7 @@ func (m *MaaSAPI) ListDNSServers() ([]v1alpha1.Nameserver, error) {
 		nameserversString := strings.Split(string(nameservers), " ")
 		nameservsersMaas := make([]v1alpha1.Nameserver, len(nameserversString))
 		for i, ns := range nameserversString {
-			nameservsersMaas[i] = v1alpha1.Nameserver{IPAddress: ns}
+			nameservsersMaas[i] = v1alpha1.Nameserver(ns)
 		}
 		return nameservsersMaas, nil
 	}