feat(connect): Cardano message signing #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
868af59 to
b9bbe42
Compare
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
b9bbe42 to
a873ff2
Compare
davidmisiak
reviewed
Jan 31, 2024
Comment on lines
170
to
172
| // todo: link docs | ||
| cardanoSignMessage: typeof cardanoSignMessage; |
There was a problem hiding this comment.
I guess the docs are missing?
davidmisiak
reviewed
Jan 31, 2024
jaskp
force-pushed
the
feat/cardano-message-signing
branch
3 times, most recently
from
5cf3111 to
b0efb54
Compare
davidmisiak
reviewed
Feb 3, 2024
| legacyResults: [legacyResults.beforeMessageSigning], | ||
| }, | ||
| ], | ||
| }; |
There was a problem hiding this comment.
Please don't forget to add more tests. I think a reasonable subset of trezor-firmware test cases would be best.
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
2def0de to
55e4576
Compare
* chore(ci): set timeout for CI validation flow * feat(ci): GH woflows run time analytics
- Flipper not allowed by default on ios but breaking the native build
- fixes conditonal top padding, the padding should be always the same independent of `isFocused` state Closes trezor#9472
* fix(suite-native): persisted message system * fix(suite-native): messages validated on device actions * fix(suite-native,message-system): fix local fallback on mobile - Conditional import for some reason start using wrong base path on mobile. Regular import on top of the file fix the issue. - Potential downside is that local config is fully bundled in the code so it can increase bundle size on web. --------- Co-authored-by: Matej Kriz <[email protected]>
…oute matching,..)
…rezor#11329) * chore(suite-native): validate invalid xpub * fixup! chore(suite-native): validate invalid xpub
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
f6ad7dd to
77cfd51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve
Screenshots: