Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new coin 4 - Polish UI/UX #11282

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Add new coin 4 - Polish UI/UX #11282

merged 1 commit into from
Feb 27, 2024

Conversation

vytick
Copy link
Contributor

@vytick vytick commented Feb 21, 2024 •
edited
Loading

  • send to account detail before it is discovered and added
  • use skeleton for loading state on account detail and address verification
  • pop back and show error if adding account fails
  • use skeleton for loading of coin price
  • visual tweaks according to design

Related Issue

Resolve #10870

Screenshots:

add_account_polished_flow.mp4

@vytick vytick added the mobile Suite Lite issues and PRs label Feb 21, 2024
@vytick vytick changed the title Polish Add coin account UI/UX Add new coin 4 - Polish UI/UX Feb 21, 2024
@vytick vytick force-pushed the feat-native-add-coin-4 branch 2 times, most recently from 600d4b7 to 58fee31 Compare February 22, 2024 14:32
@vytick vytick marked this pull request as ready for review February 22, 2024 17:58
@vytick vytick requested a review from a team as a code owner February 22, 2024 17:58
juriczech
juriczech reviewed Feb 26, 2024
View reviewed changes
suite-native/transactions/src/components/TransactionsEmptyState.tsx Outdated Show resolved Hide resolved
suite-native/navigation/src/navigators.ts Outdated Show resolved Hide resolved
suite-native/receive/src/screens/ReceiveModalScreen.tsx Show resolved Hide resolved
suite-native/module-add-accounts/src/hooks/useAddCoinAccount.ts Outdated Show resolved Hide resolved
suite-native/module-add-accounts/src/screens/AddCoinAccountScreen.tsx Outdated Show resolved Hide resolved
suite-native/navigation/src/navigators.ts Outdated Show resolved Hide resolved
suite-native/module-accounts-management/src/screens/AccountDetailScreen.tsx Show resolved Hide resolved
suite-native/module-accounts-management/src/components/CoinPriceCard.tsx Show resolved Hide resolved
PeKne
PeKne requested changes Feb 26, 2024
View reviewed changes
suite-common/wallet-core/src/accounts/accountsReducer.ts Outdated Show resolved Hide resolved
suite-native/accounts/src/components/AddAccountsButton.tsx Outdated Show resolved Hide resolved
suite-native/module-accounts-management/src/components/CoinPriceCard.tsx Show resolved Hide resolved
suite-native/module-accounts-management/src/screens/AccountDetailScreen.tsx Outdated Show resolved Hide resolved
suite-native/module-accounts-management/src/screens/AccountsScreen.tsx Outdated Show resolved Hide resolved
suite-native/module-receive/src/screens/ReceiveAccountsScreen.tsx Outdated Show resolved Hide resolved
suite-native/transactions/src/components/TransactionsEmptyState.tsx Show resolved Hide resolved
suite-native/navigation/src/navigators.ts Show resolved Hide resolved
@vytick vytick force-pushed the feat-native-add-coin-4 branch from bb6bfa6 to 32b241b Compare February 27, 2024 11:00
@vytick vytick mentioned this pull request Feb 27, 2024
Closed
@vytick
Copy link
Contributor Author

vytick commented Feb 27, 2024

/rebase

@github-actions GitHub Actions
Copy link

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/8065161720

@trezor-ci trezor-ci force-pushed the feat-native-add-coin-4 branch from 32b241b to 6ecb877 Compare February 27, 2024 13:01
@vytick vytick merged commit ce82b09 into develop Feb 27, 2024
6 checks passed
@vytick vytick deleted the feat-native-add-coin-4 branch February 27, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejkriz matejkriz matejkriz left review comments

@juriczech juriczech juriczech approved these changes

@PeKne PeKne PeKne approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs
Projects
No open projects
Suite Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new coin 4 - polish empty account state
4 participants
@vytick @matejkriz @PeKne @juriczech