feat(suite-native): Add coin behind feature flag #11332
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
Tested on emulator and works as expected. |
|
/rebase |
vytick
force-pushed
the
feat-native-add-coin-0
branch
from
18d2df3 to
1b1854c
Compare
suite-native/accounts/src/components/SearchableAccountsListScreenHeader.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| export const AddAccountButton = () => { | ||
| const isSelectedDevicePortfolioTracker = useSelector(selectIsPortfolioTrackerDevice); | ||
| const [isAddCoinAccountEnabled] = useFeatureFlag(FeatureFlag.IsAddCoinAccountEnabled); | ||
| const [isDeviceConnectEnabled] = useFeatureFlag(FeatureFlag.IsDeviceConnectEnabled); |
There was a problem hiding this comment.
Why you don't use this feature flag inside of isAddCoinAccountEnabled, these two are closely tied and there will never be adding of new account without device
There was a problem hiding this comment.
The way feature flags are written now, I cant use IsDeviceConnectEnabled setting as a base for IsAddCoinAccountEnabled.
And we will probably remove IsAddCoinAccountEnabled flag in next release anyway and only use IsDeviceConnectEnabled.
There was a problem hiding this comment.
It is there only to hide it for the release and still let qa and us to test it
There was a problem hiding this comment.
Just simply create hook which will use both of these flags
|
@SocketSecurity ignore-all |
|
/rebase |
trezor-ci
force-pushed
the
feat-native-add-coin-0
branch
from
d7ea06e to
96631c5
Compare
|
/rebase |
trezor-ci
force-pushed
the
feat-native-add-coin-0
branch
from
2e309f9 to
9e31005
Compare
Hides Add Account functionality by disabling ( + ) button and choosing correct flow on tap
Related Issue
Resolve #11295