-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always install webpack plugins #9718
Conversation
Plugin installation can be skipped by defining `"update": false,` in installed package.json of plugin under node_modules
flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskInstallWebpackPlugins.java
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskInstallWebpackPlugins.java
Show resolved
Hide resolved
SonarQube analysis reported 1 issue Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to cover this feature by a unit test so that not to accidentally change or lost it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what this does is it leaves it up for the user to decide if they don't want to reinstall the plugins ?
And then it doesn't matter if we forget to update the version of the plugin when doing changes ?
A bit unsure why this is needed or better as there was no ticket or discussion on this.
A unit test would be nice to make sure nobody accidentally removes the "feature of skipping installing the plugins" but first we should probably agree that do we want to merge this or not.
Seeing as the instance of not wanting to install the plugins is more for our development needs on the plugins and not for the end user. Opting out of plugin installation makes it clearer that this is the version used and can be used for making changes before committing to build a new flow-server+maven-plugin instance. |
If we see this as an internal feature then I don't think the tests are required
Plugin installation can be skipped by defining `"update": false,` in installed package.json of plugin under node_modules
Plugin installation can be skipped by defining `"update": false,` in installed package.json of plugin under node_modules
Plugin installation can be skipped by defining `"update": false,` in installed package.json of plugin under node_modules
Plugin installation can be skipped by defining `"update": false,` in installed package.json of plugin under node_modules
Plugin installation can be skipped
by defining
"update": false,
in installedpackage.json of plugin under node_modules