Always install webpack plugins (#9718)

Plugin installation can be skipped by defining `"update": false,` in installed package.json of plugin under node_modules
vaadin · Feb 12, 2021 · 7c225a8 · 7c225a8
1 parent f442e76
commit 7c225a8
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskInstallWebpackPlugins.java b/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskInstallWebpackPlugins.java
@@ -120,14 +120,8 @@ private void generatePluginFiles(String pluginName) throws IOException {
             String packageFile = FileUtils
                 .readFileToString(new File(pluginTargetFile, PACKAGE_JSON),
                     StandardCharsets.UTF_8);
-            final FrontendVersion packageVersion = new FrontendVersion(
-                Json.parse(packageFile).getString("version"));
-            FrontendVersion pluginVersion = new FrontendVersion(
-                packageJson.getString("version"));
-            if (packageVersion.isEqualTo(pluginVersion)) {
-                log().debug(
-                    "Skipping install of {} for version {} already installed",
-                    pluginName, pluginVersion.getFullVersion());
+            final JsonObject targetJson = Json.parse(packageFile);
+            if(targetJson.hasKey("update") && !targetJson.getBoolean("update")) {
                 return;
             }
         }