Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always install webpack plugins #9718

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Always install webpack plugins #9718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskInstallWebpackPlugins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,8 @@ private void generatePluginFiles(String pluginName) throws IOException {
String packageFile = FileUtils
.readFileToString(new File(pluginTargetFile, PACKAGE_JSON),
StandardCharsets.UTF_8);
final FrontendVersion packageVersion = new FrontendVersion(
Json.parse(packageFile).getString("version"));
FrontendVersion pluginVersion = new FrontendVersion(
packageJson.getString("version"));
if (packageVersion.isEqualTo(pluginVersion)) {
mshabarov marked this conversation as resolved.
Show resolved Hide resolved
log().debug(
"Skipping install of {} for version {} already installed",
pluginName, pluginVersion.getFullVersion());
final JsonObject targetJson = Json.parse(packageFile);
if(targetJson.hasKey("update") && !targetJson.getBoolean("update")) {
mshabarov marked this conversation as resolved.
Show resolved Hide resolved
return;
}
}
Expand Down