Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute JS in the very end of the message processing event loop #4459

Merged
merged 2 commits into from
Aug 1, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Jul 31, 2018

Fixes #4444


This change is Reviewable

Copy link
Contributor

@gilberto-torrezan gilberto-torrezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

@gilberto-torrezan gilberto-torrezan merged commit 491992e into master Aug 1, 2018
@gilberto-torrezan gilberto-torrezan deleted the 4444-refresh-visible-grid branch August 1, 2018 06:42
denis-anisimov pushed a commit that referenced this pull request Aug 1, 2018
* Execute JS in the very end of the message processing event loop

Fixes #4444

* Move JS execution via post flush listener after all listeners
gilberto-torrezan pushed a commit that referenced this pull request Aug 1, 2018
* Execute JS in the very end of the message processing event loop

Fixes #4444

* Move JS execution via post flush listener after all listeners
@gilberto-torrezan gilberto-torrezan mentioned this pull request Aug 1, 2018
@pekam pekam added this to the 1.1.0.alpha3 milestone Aug 1, 2018
gilberto-torrezan added a commit to vaadin/vaadin-grid-flow that referenced this pull request Aug 1, 2018
The issue #71 was fixed by the changes introduced with
vaadin/flow#4459
denis-anisimov pushed a commit to vaadin/vaadin-grid-flow that referenced this pull request Aug 1, 2018
The issue #71 was fixed by the changes introduced with
vaadin/flow#4459
gilberto-torrezan added a commit to vaadin/vaadin-grid-flow that referenced this pull request Aug 1, 2018
The issue #71 was fixed by the changes introduced with
vaadin/flow#4459
gilberto-torrezan added a commit to vaadin/vaadin-grid-flow that referenced this pull request Aug 1, 2018
The issue #71 was fixed by the changes introduced with
vaadin/flow#4459
denis-anisimov pushed a commit to vaadin/vaadin-grid-flow that referenced this pull request Aug 2, 2018
The issue #71 was fixed by the changes introduced with
vaadin/flow#4459
gilberto-torrezan added a commit to vaadin/vaadin-grid-flow that referenced this pull request Aug 2, 2018
The issue #71 was fixed by the changes introduced with
vaadin/flow#4459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants