Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #4397 #4468

Closed

Conversation

gilberto-torrezan
Copy link
Contributor

@gilberto-torrezan gilberto-torrezan commented Aug 1, 2018

This PR reverts the changes introduced by #4397 (but still preserves the tests).

The underlying issue was fixed by this PR #4459


This change is Reviewable

@gilberto-torrezan gilberto-torrezan added this to the 1.1.0.alpha3 milestone Aug 1, 2018
@gilberto-torrezan gilberto-torrezan self-assigned this Aug 1, 2018
@pekam pekam removed this from the 1.1.0.alpha3 milestone Aug 1, 2018
@gilberto-torrezan gilberto-torrezan added this to the Abandoned milestone Aug 1, 2018
@gilberto-torrezan
Copy link
Contributor Author

Closing this PR since reverting the changes makes the issue #4353 reappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants