Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute JS in the very end of the message processing event loop #4459

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Execute JS in the very end of the message processing event loop #4459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
253c118
Execute JS in the very end of the message processing event loop
Jul 31, 2018
9941ddd
Move JS execution via post flush listener after all listeners
Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions flow-client/src/main/java/com/vaadin/client/communication/MessageHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,14 @@ assert getServerId(valueMap) == -1

if (json.hasKey(JsonConstants.UIDL_KEY_EXECUTE)) {
// Invoke JS only after all tree changes have been
// propagated
// propagated and after post flush listeners added during
// message processing (so add one more post flush listener which
// is called after all added post listeners).
Reactive.addPostFlushListener(
() -> registry.getExecuteJavaScriptProcessor().execute(
json.getArray(JsonConstants.UIDL_KEY_EXECUTE)));
() -> Reactive.addPostFlushListener(() -> registry
.getExecuteJavaScriptProcessor()
.execute(json.getArray(
JsonConstants.UIDL_KEY_EXECUTE))));
}

Console.log("handleUIDLMessage: "
Expand Down