feat: make Scroller implement Focusable #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
web-padawan
reviewed
Nov 22, 2023
...ed-layout-flow/src/test/java/com/vaadin/flow/component/orderedlayout/tests/ScrollerTest.java
Show resolved
Hide resolved
brunovianarezende
force-pushed
the
make-scroller-implement-focusable
branch
from
5a08277 to
561e5f4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Nov 23, 2023
|
This ticket/PR has been released with Vaadin 24.3.0.beta1 and is also targeting the upcoming stable 24.3.0 version. |
sissbruecker
added a commit
that referenced
this pull request
Jan 11, 2024
* feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 * chore: minor javadoc improvement * chore: improve javadoc of AbstractLogin.getI18n() * refactoring: rename setErrorMessage() to showErrorMessage() * feat: make Scroller implement Focusable (#5738) * small cleanup and test improvements --------- Co-authored-by: Bruno Rezende <[email protected]> Co-authored-by: Sascha Ißbrücker <[email protected]>
|
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3766
Added Focusable interface to Scroller.
Type of change
Checklist
Additional for
Featuretype of change