Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroller is missing interface Focusable #3766

Closed
aley2003 opened this issue Sep 22, 2022 · 1 comment · Fixed by #5738
Closed

Scroller is missing interface Focusable #3766

aley2003 opened this issue Sep 22, 2022 · 1 comment · Fixed by #5738
Labels
enhancement New feature or request good first issue Good for newcomers vaadin-scroller

Comments

@aley2003
Copy link

Description

A Scroller component receives focus with tab or mouse clicks but does not implement Focusable.
So it is not possible to forbit focusing a Scroller with setTabIndex(-1) or focus a Scroller with focus(),

Expected outcome

A Scroller implementing Focusable

Minimal reproducible example

VerticalLayout layout = new VerticalLayout (
new TextField(),
new Scroller(new Html("Text in Sccroller")));

Steps to reproduce

Create Layout with a Scroller
Press tab -> Scroller will be focused, no possibility to prevent this from Java

Environment

Vaadin version(s): 23.2.1
OS: Windows

Browsers

No response

@web-padawan web-padawan added enhancement New feature or request vaadin-scroller good first issue Good for newcomers labels Sep 22, 2022
@web-padawan
Copy link
Member

Thanks for the issue. This is an oversight from our side, we forgot to add Focusable after implementing the corresponding change in the web component: vaadin/web-components#3107. This should be changed, probably in 23.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers vaadin-scroller
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants