Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New API for setting error title and message directly #1525

Closed
DiegoCardoso opened this issue Jan 29, 2019 · 2 comments · Fixed by #5749
Closed

New API for setting error title and message directly #1525

DiegoCardoso opened this issue Jan 29, 2019 · 2 comments · Fixed by #5749
Labels
enhancement New feature or request vaadin-login

Comments

@DiegoCardoso
Copy link
Contributor

No description provided.

@sebdavid
Copy link

sebdavid commented May 5, 2020

Currently, I change the error message dynamically by doing :

loginI18n.getErrorMessage().setTitle("The new error message");
loginForm.setI18n(loginI18n);
loginForm.setError(true);

But I agree that it would be nice to do that on the loginForm directly. LoginI18n should be used only for the initialization.

@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-login-flow Oct 6, 2020
@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-login May 19, 2021
@vaadin-bot vaadin-bot transferred this issue from vaadin/web-components May 21, 2021
@web-padawan web-padawan added the enhancement New feature or request label Jun 24, 2022
mvysny added a commit that referenced this issue Nov 21, 2023
@mvysny
feat: Add AbstractLogin.setErrorMessage(). Fixes #1525
9f38855
@mvysny
Copy link
Member

mvysny commented Nov 21, 2023

Acceptance criteria: AbstractLogin now offers the setErrorMessage(String title, String message) function, which shows the error message on the LoginForm or LoginOverlay component, and also calls setError(true).

@mvysny mvysny mentioned this issue Nov 21, 2023
Merged
10 tasks
sissbruecker added a commit that referenced this issue Jan 11, 2024
@mvysny @brunovianarezende @sissbruecker
feat: add AbstractLogin.showErrorMessage() (#5749)
7e21fcb 
* feat: Add AbstractLogin.setErrorMessage(). Fixes #1525

* chore: minor javadoc improvement

* chore: improve javadoc of AbstractLogin.getI18n()

* refactoring: rename setErrorMessage() to showErrorMessage()

* feat: make Scroller implement Focusable (#5738)

* small cleanup and test improvements

---------

Co-authored-by: Bruno Rezende <[email protected]>
Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request vaadin-login
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add AbstractLogin.showErrorMessage() vaadin/flow-components
5 participants
@mvysny @DiegoCardoso @sebdavid @web-padawan @vaadin-bot