-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!(BigDecimalField): use custom logic instead of validated event #5581
Conversation
854687f
to
77c7052
Compare
I added tests for eager mode and they uncovered that there is an unexpected initial validation that is caused by the We've already encountered this kind of issue before: see #2878 that fixes it for DatePicker. In short, such |
eebf3c8
to
3b20298
Compare
50cfbe1
to
74b2907
Compare
17e618b
to
119d119
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |
Description
The PR refactors BigDecimalField to make it trigger validation whenever a
value-changed
event is received from the client while the value still remains empty on the server, instead of relying on thevalidated
event.Depends on
Part of #5537
Type of change