fix: ensure DatePicker initializes client side value property #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
vursen
changed the title
vursen
force-pushed
the
fix/date-picker/initial-value
branch
from
c70b474 to
2cedc9b
Compare
vursen
force-pushed
the
fix/date-picker/initial-value
branch
from
4b52ecc to
3025f95
Compare
vursen
changed the title
vursen
force-pushed
the
fix/date-picker/initial-value
branch
3 times, most recently
from
2577924 to
4b52ecc
Compare
...t/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java
Outdated
Show resolved
Hide resolved
...t/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java
Outdated
Show resolved
Hide resolved
vursen
commented
Mar 17, 2022
...icker-flow/src/main/java/com/vaadin/flow/component/datepicker/GeneratedVaadinDatePicker.java
Show resolved
Hide resolved
sissbruecker
approved these changes
Mar 17, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
Co-authored-by: Sascha Ißbrücker <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
Co-authored-by: Sascha Ißbrücker <[email protected]>
vursen
added a commit
that referenced
this pull request
Mar 18, 2022
…#2880) Co-authored-by: Sascha Ißbrücker <[email protected]> Co-authored-by: Sergey Vinogradov <[email protected]>
vursen
added a commit
that referenced
this pull request
Mar 18, 2022
…#2881) Co-authored-by: Sergey Vinogradov <[email protected]> Co-authored-by: Sascha Ißbrücker <[email protected]>
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes DatePicker so that it initializes the web component's
valueproperty with an empty string rather than leave it to benullwhen DatePicker is being instantiated with no value. This is needed to prevent thevalue-changedevent on the server side which happens as a result of Polymer convertingnullto"".It pretty much reproduces the fix made for Select a while ago in 14676de#diff-1c027c9076652ce3a2c641ac7407c10cc3a87846a37ee152c27aa9fe59aad609R126-R129
The same fix will be made for TimePicker, but in a separate PR.
Part of #2691
Type of change
Checklist