do not assert the number of validation runs in eager mode

vaadin · Oct 18, 2023 · 17e618b · 17e618b
1 parent 74b2907
commit 17e618b
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 30 deletions.
diff --git a/...n/flow/component/textfield/tests/validation/BigDecimalFieldEagerBinderValidationPage.java b/...n/flow/component/textfield/tests/validation/BigDecimalFieldEagerBinderValidationPage.java
@@ -45,9 +45,6 @@ public BigDecimalFieldEagerBinderValidationPage() {
 
         Binder<Bean> binder = new Binder<>(Bean.class);
         binder.forField(testField).bind("property");
-        binder.addStatusChangeListener(event -> {
-            incrementServerValidationCounter();
-        });
     }
 
     protected BigDecimalField createTestField() {

diff --git a/.../vaadin/flow/component/textfield/tests/validation/BigDecimalFieldEagerValidationPage.java b/.../vaadin/flow/component/textfield/tests/validation/BigDecimalFieldEagerValidationPage.java
@@ -29,12 +29,6 @@ public BigDecimalFieldEagerValidationPage() {
     }
 
     protected BigDecimalField createTestField() {
-        return new BigDecimalField() {
-            @Override
-            protected void validate() {
-                super.validate();
-                incrementServerValidationCounter();
-            }
-        };
+        return new BigDecimalField();
     }
 }
diff --git a/...din/flow/component/textfield/tests/validation/BigDecimalFieldEagerBinderValidationIT.java b/...din/flow/component/textfield/tests/validation/BigDecimalFieldEagerBinderValidationIT.java
@@ -27,33 +27,36 @@ public class BigDecimalFieldEagerBinderValidationIT
         extends AbstractValidationIT<BigDecimalFieldElement> {
     @Test
     public void enterChars_fieldValidatesOnEveryChar() {
+        // Entered: 2
+        testField.sendKeys("2");
+        assertServerValid();
+        assertClientValid();
+
+        // Entered:
+        testField.sendKeys(Keys.BACK_SPACE);
+        assertServerValid();
+        assertClientValid();
+    }
+
+    @Test
+    public void badInput_enterChars_fieldValidatesOnEveryChar() {
         // Entered: -
         testField.sendKeys("-");
-        assertValidationCount(1);
         assertServerInvalid();
         assertClientInvalid();
 
-        resetValidationCount();
-
         // Entered: -2
         testField.sendKeys("2");
-        assertValidationCount(1);
         assertServerValid();
         assertClientValid();
 
-        resetValidationCount();
-
         // Entered: -
         testField.sendKeys(Keys.BACK_SPACE);
-        assertValidationCount(1);
         assertServerInvalid();
         assertClientInvalid();
 
-        resetValidationCount();
-
         // Entered:
         testField.sendKeys(Keys.BACK_SPACE);
-        assertValidationCount(1);
         assertServerValid();
         assertClientValid();
     }

diff --git a/...om/vaadin/flow/component/textfield/tests/validation/BigDecimalFieldEagerValidationIT.java b/...om/vaadin/flow/component/textfield/tests/validation/BigDecimalFieldEagerValidationIT.java
@@ -27,33 +27,36 @@ public class BigDecimalFieldEagerValidationIT
         extends AbstractValidationIT<BigDecimalFieldElement> {
     @Test
     public void enterChars_fieldValidatesOnEveryChar() {
+        // Entered: 2
+        testField.sendKeys("2");
+        assertServerValid();
+        assertClientValid();
+
+        // Entered:
+        testField.sendKeys(Keys.BACK_SPACE);
+        assertServerValid();
+        assertClientValid();
+    }
+
+    @Test
+    public void badInput_enterChars_fieldValidatesOnEveryChar() {
         // Entered: -
         testField.sendKeys("-");
-        assertValidationCount(1);
         assertServerInvalid();
         assertClientInvalid();
 
-        resetValidationCount();
-
         // Entered: -2
         testField.sendKeys("2");
-        assertValidationCount(1);
         assertServerValid();
         assertClientValid();
 
-        resetValidationCount();
-
         // Entered: -
         testField.sendKeys(Keys.BACK_SPACE);
-        assertValidationCount(1);
         assertServerInvalid();
         assertClientInvalid();
 
-        resetValidationCount();
-
         // Entered:
         testField.sendKeys(Keys.BACK_SPACE);
-        assertValidationCount(1);
         assertServerValid();
         assertClientValid();
     }