-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdbuf: make build more reliable and allow installation using Cargo #1120
Conversation
5c81378
to
cf7582c
Compare
Also note that this means we can now go on crates.io. |
that's great, sadly building on windows with current rust is still being a bit messed up |
How are you building? I just built it on Windows. |
rustc 1.22.1 (05e2e1c41 2017-11-22) maybe I had problem before because I've used to run cargo update or something and new win32 crate has serious changes |
Ah okay. I was having issues earlier because I forgot |
Hi! Cloning the repo and installing using Any ideas why cargo install --git https://github.com/uutils/coreutils uutils might fail? It is hard for me to parse, but I think it reports an issue in the |
Which version of the compiler are you using? If it’s repeatable something may have changed in Cargo. |
Latest stable and nightly with same results. oliver:~# rustup show
Default host: x86_64-unknown-linux-gnu
installed toolchains
--------------------
stable-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu
active toolchain
----------------
stable-x86_64-unknown-linux-gnu (default)
rustc 1.23.0 (766bd11c8 2018-01-01) |
@bugabinga sorry it has taken so long to respond. Interestingly, this issue only seems to happen when installing like |
@bugabinga from looking at Cargo bugs, it may be related to something like this. |
@bugabinga sorry it has taken so long to respond. Interestingly, this issue only seems to happen when installing like cargo --git https://github.com/uutils/coreutils uutils. If you clone the repository and run cargo install from there, it seems to work just fine.
Yes, I was aware. Sorry for not mentioning that.
The bug you linked gives some clues , so I will test some more later and report back.
|
Now instead of trying to finagle Cargo into giving us a shared library that we then have to find and inject into anything called by
stdbuf
, we just generate the library on the fly by embedding it intostdbuf
. This allows us to installstdbuf
using Cargo, so now everything can be built using just Cargo (yay).I think this is enough that we can close #1104.