Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdbuf: make build more reliable and allow installation using Cargo #1120

Merged
merged 1 commit into from
Dec 30, 2017

Conversation

Arcterus
Copy link
Collaborator

Now instead of trying to finagle Cargo into giving us a shared library that we then have to find and inject into anything called by stdbuf, we just generate the library on the fly by embedding it into stdbuf. This allows us to install stdbuf using Cargo, so now everything can be built using just Cargo (yay).

I think this is enough that we can close #1104.

@cnd cnd merged commit 9b941c5 into uutils:master Dec 30, 2017
@Arcterus
Copy link
Collaborator Author

Arcterus commented Dec 30, 2017

Also note that this means we can now go on crates.io.

@cnd
Copy link
Contributor

cnd commented Dec 31, 2017

that's great, sadly building on windows with current rust is still being a bit messed up

@Arcterus
Copy link
Collaborator Author

How are you building? I just built it on Windows.

@cnd
Copy link
Contributor

cnd commented Dec 31, 2017

rustc 1.22.1 (05e2e1c41 2017-11-22)
building fine currently

maybe I had problem before because I've used to run cargo update or something and new win32 crate has serious changes

@Arcterus
Copy link
Collaborator Author

Ah okay. I was having issues earlier because I forgot unix was a default feature.

@bugabinga
Copy link

Hi!

Cloning the repo and installing using cargo install now works fine. Good work!

Any ideas why

cargo install  --git https://github.com/uutils/coreutils uutils

might fail?

Backtrace

It is hard for me to parse, but I think it reports an issue in the build.rs of stdbuf.

@Arcterus
Copy link
Collaborator Author

Which version of the compiler are you using? If it’s repeatable something may have changed in Cargo.

@bugabinga
Copy link

Latest stable and nightly with same results.

oliver:~# rustup show
Default host: x86_64-unknown-linux-gnu
installed toolchains
--------------------
stable-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu
active toolchain
----------------
stable-x86_64-unknown-linux-gnu (default)
rustc 1.23.0 (766bd11c8 2018-01-01)

@Arcterus
Copy link
Collaborator Author

Arcterus commented Mar 2, 2018

@bugabinga sorry it has taken so long to respond. Interestingly, this issue only seems to happen when installing like cargo --git https://github.com/uutils/coreutils uutils. If you clone the repository and run cargo install from there, it seems to work just fine.

@Arcterus
Copy link
Collaborator Author

Arcterus commented Mar 2, 2018

@bugabinga from looking at Cargo bugs, it may be related to something like this.

@bugabinga
Copy link

bugabinga commented Mar 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider slimming down the make stuff
3 participants