Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo install --git ignores Cargo.lock #4263

Closed
lilianmoraru opened this issue Jul 9, 2017 · 1 comment
Closed

cargo install --git ignores Cargo.lock #4263

lilianmoraru opened this issue Jul 9, 2017 · 1 comment
Labels
Command-install S-needs-team-input Status: Needs input from team on whether/how to proceed.

Comments

@lilianmoraru
Copy link

cargo version: cargo 0.21.0-nightly (4c0a8b63d 2017-06-27)

It seems that currently cargo install --git( cargo install doesn't have this issue ) ignores Cargo.lock by default.

Example project here would be ripgrep.
Running this command:

RUSTFLAGS="-C target-cpu=native" cargo +nightly install --git https://github.com/BurntSushi/ripgrep.git --features 'simd-accel avx-accel'

will result in clap being picked with the version 2.25.0, which could of been a breaking API change, compared with the one included in Cargo.lock.

If I clone the repo and build the project myself:

RUSTFLAGS="-C target-cpu=native" cargo +nightly build --release --features 'simd-accel avx-accel'

clap v2.24.1 is being picked-up from Cargo.lock.

@epage
Copy link
Contributor

epage commented Oct 13, 2023

This looks to be a subset of #7169 which has a lot more discussion. Closing in favor of that. If there was something I overlooked, let us know!

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-install S-needs-team-input Status: Needs input from team on whether/how to proceed.
Projects
None yet
Development

No branches or pull requests

4 participants