Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider slimming down the make stuff #1104

Closed
nox opened this issue Dec 6, 2017 · 7 comments · Fixed by #1120
Closed

Consider slimming down the make stuff #1104

nox opened this issue Dec 6, 2017 · 7 comments · Fixed by #1120

Comments

@nox
Copy link

nox commented Dec 6, 2017

Why does this project require make to build?

@Arcterus
Copy link
Collaborator

Arcterus commented Dec 6, 2017

Most of the build/installation instructions are from before Cargo existed. You can use Cargo to build the project (although make is still required due to the build process for stdbuf). However, installing requires make because (as far as I know) Cargo does not support the creation of symlinks to another binary or the installation of man pages (which will eventually be written).

@nox
Copy link
Author

nox commented Dec 6, 2017

(although make is still required due to the build process for stdbuf).

There is nothing in that crate's makefile that couldn't be done directly in build.rs AFAIK.

Man pages does need something more than cargo, but the README should make it clear one can just invoke cargo to build.

@Arcterus
Copy link
Collaborator

Arcterus commented Dec 7, 2017

Yeah, the README instructions do need to be updated.

I'm not really satisfied with stdbuf's build process, so I'll see if there's a better way using build.rs later.

@Arcterus
Copy link
Collaborator

Arcterus commented Dec 7, 2017

I've updated the README in #1105.

@nox
Copy link
Author

nox commented Dec 7, 2017

I'm not really satisfied with stdbuf's build process, so I'll see if there's a better way using build.rs later.

Why is libstdbuf needed in the first place, can't we just setup the IO stuff from stdbuf's main function?

@Arcterus
Copy link
Collaborator

Arcterus commented Dec 7, 2017

setvbuf() doesn't affect programs started using exec() functions, so we need to use the constructor attribute and LD_PRELOAD to actually modify the buffering in the executed program.

@Arcterus
Copy link
Collaborator

Arcterus commented Dec 9, 2017

make will no longer be required to build stdbuf once #1106 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants