Organize directories

[niwhsa9]

have not tested, I can guarantee I broke some launch files though. #28

[CameronTressler]

I think we should decide now, are we gonna be sticklers about adding newlines at the ends of files? I'm honestly kind of indifferent, but I know people (I think at least Matt Martin?) have made that comment on PRs in the past and I think we should be consistent about whether or not we care. What are your guys thoughts?

[niwhsa9]

i'm also indifferent but it definitely sounds like the thing that @qhdwight might have a strong opinion on lmao. What do you think Q? Its possible that our style checker is already enforcing too

[qhdwight]

i'm also indifferent but it definitely sounds like the thing that @qhdwight might have a strong opinion on lmao. What do you think Q? Its possible that our style checker is already enforcing too

I don't really have a strong opinion. Usually I add a newline. What I care about is consistency with bracing, newlines, etc. in the actual code. I also took a look on if we could enforce this with clang tidy but I didn't find an easy answer.

[qhdwight]

I'll take a look at this after it compiles

[rbridges12]

Had to merge master in order to fix the merge conflicts, CI now runs and passes so this should be ready for review

[qhdwight]

Including the .vscode folder was intentional? Since usually checking in project generated stuff is not done. I suppose ROS nonstandard to set up so that is why this is here?

[qhdwight]

I think we should also prefer the longer names, such as perception.launch as opposed to percep.launch. The folders are currently like this but not all files.

[rbridges12]

Including the .vscode folder was intentional? Since usually checking in project generated stuff is not done. I suppose ROS nonstandard to set up so that is why this is here?

@niwhsa9 added that, not sure if it was intentional or not

[tabiosg]

I think there's a bunch of issues with file paths now that this PR moves a bunch of files around.

Stuff got moved into the config/ folder, so the references to it will have to be changed (maybe also add to CMakeLists.txt?). e.g. It still says params/ekf_localization.yaml in nav.launch and loc.launch. I'm also not sure what control.yaml does. Also a bunch of files still say env_description and all of the .rviz files are not linked properly in the .launch files.

EDIT: that all being said, IDK how CI passes so maybe I'm just really really dumb

[niwhsa9]

nah @tabiosg u prob right, CI only does a catkin build so there's a good chance a ton of other stuff is broke.

@rbridges12 unintentional, we can gitignore that. Although if people like vscode I can add my launch jsons that let you run ROS python nodes properly with the debugger.

[rbridges12]

@niwhsa9 I think that would be useful, wanna do that here or later in a different PR?

[niwhsa9]

Diff PR because I'll need to change them to use environment variables as opposed to my hardcoded directories

[rbridges12]

All of @tabiosg concerns should be fixed now, I ran all the launch files and saw zero errors, and everything looked normal

[tabiosg]

concerns have vanished

[rbridges12]

I'm pretty sure config.yaml is from when we used a different sim velocity controller, so its now useless. I couldnt find any reference to it in the code. Can I delete @niwhsa9?

[niwhsa9]

Yeah I think ur right

[qhdwight]

I've tested this with nav stuff and everything worked well so I'm down to merge this. Perhaps we could do the short -> long names like I was talking about but that can also come later.

[rbridges12]

Yeah I'd say add the long names and then lets merge