Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly compute TP, FP in val.py #5727

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Explicitly compute TP, FP in val.py #5727

merged 1 commit into from
Nov 20, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 20, 2021

Compute TP, FP from Precision, Recall, and target count. Leave values in val.py.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced average precision computation in object detection metrics for clarity and reliability.

📊 Key Changes

  • Added an eps parameter to prevent division by zero in calculations.
  • Refactored to use the true label counts directly from unique class counts for better performance.
  • Introduced explicit true and false positive count outputs to the precision-recall curve function.
  • Updated associated functions to handle the new outputs on true and false positives.

🎯 Purpose & Impact

  • 🎯 Purpose: To improve the numerical stability and accuracy of the object detection metrics.
  • 🚀 Impact: Users will experience more reliable performance metrics, which are crucial for evaluating and improving object detection models.
  • 🧑‍💻 Developers: Can easily interpret the impact of their models' precision and recall due to the clearer computation of true and false positives.
  • 🛠️ Overall: This change facilitates a more robust and transparent evaluation of object detection systems.

@glenn-jocher glenn-jocher self-assigned this Nov 20, 2021
@glenn-jocher glenn-jocher merged commit 36d12a5 into master Nov 20, 2021
@glenn-jocher glenn-jocher deleted the update/tpfp branch November 20, 2021 00:04
@glenn-jocher glenn-jocher linked an issue Nov 20, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher linked an issue Nov 20, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher linked an issue Nov 20, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher linked an issue Nov 20, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher linked an issue Nov 20, 2021 that may be closed by this pull request
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment