Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Initial multiclock support in token channels & synthesizable unit tests #90

Merged
merged 8 commits into from
Oct 8, 2018
Merged

[RFC] Initial multiclock support in token channels & synthesizable unit tests #90

merged 8 commits into from
Oct 8, 2018

Conversation

davidbiancolin
Copy link
Contributor

@davidbiancolin davidbiancolin commented Sep 28, 2018 •
edited
Loading

This is big change, but not one that should affect default FireSim targets. There are three major additions here, they can be factored into two different PRs if that's desired.

  1. Adds preliminary multiclock support in channels between the transformed-RTL and endpoints
    • Restricted to integer / reciprocal clock ratios
    • Channel generation introspects on endpoint clock-ratio during Simulation Mapping
  2. Adds synthesizable unittest generation framework
    • Derived from RocketChip's unittest package
    • Generator (App) lives in src/main/scala/midas
    • Makefrag lives in src/main/cc/unittest
  3. Reworks the build system for RTL simulation (MIDAS-level)
    • to share code between unittests, and MIDAS-level simulations
    • recipes for building VCS and Verilator simulators moved to src/main/cc/rtlsim

@davidbiancolin
Model integer clock div/mul between RTL and endpoints
80d99e5 
This is achieved by duplicating or combining tokens in the channels
generated in the SimWrapper. Simulation wrapper generation inspects
a new clockRatio member introduced to the Endpoint trait
@davidbiancolin
Fix a bug where vpd names were being clipped
93ea388
@davidbiancolin
Add RC-style unittests for channels
16ff76c 
Parent projects can generate MIDAS unittests by using the Makefrag
provided resources/midas/unittest.
@davidbiancolin
[Channels] Fix a bug where target-data was falsely enqueued
4576e2b
@davidbiancolin
[Channels] Do some simple bounds checking on output tokens
9fbc438
@davidbiancolin
Merge remote-tracking branch 'origin/dev' into firesim-multiclock
29e70e5
@davidbiancolin
Factor out recipes for building SW RTL simulators into Makefrags
a1abbc1
@davidbiancolin
Shuffle around RTL simulation and unittest makefrags
80137ec
@davidbiancolin davidbiancolin mentioned this pull request Sep 28, 2018
Merged
sagark
sagark approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@sagark sagark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taeksangsong taeksangsong merged commit ff52eaf into dev Oct 8, 2018
This was referenced Oct 8, 2018
Merged
Merged
@sagark sagark mentioned this pull request Oct 12, 2018
Merged
3 tasks
@davidbiancolin davidbiancolin deleted the firesim-multiclock branch March 25, 2019 23:09
davidbiancolin pushed a commit to davidbiancolin/midas that referenced this pull request Oct 18, 2019
@taeksangsong
[MIDAS] Merge pull request ucb-bar#90 from ucb-bar/firesim-multiclock
dd615d6 
[RFC] Initial multiclock support in token channels & synthesizable unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagark sagark sagark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidbiancolin @sagark @taeksangsong