-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model clock-domain crossings between transformed-RTL model and endpoints #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 87ff72c.
davidbiancolin
changed the title
[WIP] Model clock-domain crossings between transformed-RTL model and endpoints
Model clock-domain crossings between transformed-RTL model and endpoints
Sep 28, 2018
Re: fast-install toolchain, I don't think we expect it to work on millennium. We'd have to have a separate package for that. |
sagark
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was one RTL-changing bugfix to the RV channel implementation.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated midas PR: ucb-bar/midas#90. See that PR for more detail.
As for FireSim specific stuff:
Some unrelated changes that could be dropped:
Ultimately we probably want to model 1:3 or 1:2 division between Rocket Chip and the DRAM model by default but i'm seeing some weird behavior in the QC-FRFCFS instances that must be addressed before that can even be considered.