Add empty resource rule if using resource union. #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kageiit
approved these changes
May 4, 2017
| apply plugin: 'com.android.library' | ||
| apply plugin: 'me.tatarka.retrolambda' | ||
|
|
||
| android { |
There was a problem hiding this comment.
you dont need the empty android block
kageiit
suggested changes
May 4, 2017
| @@ -0,0 +1,10 @@ | |||
| apply plugin: 'com.android.library' | |||
| apply plugin: 'me.tatarka.retrolambda' | |||
This ensures that an R file is created for that module even if there are no resources. Gradle always generates an R file for each module even if there are no resources.
runningcode
force-pushed
the
no/resource-rule
branch
from
27fc981 to
d4d6411
Compare
|
Removed retrolambda and removed empty android block. |
cwoodwar6
pushed a commit
to cwoodwar6/okbuck
that referenced
this pull request
May 10, 2017
* uber/master: Use stream instead of parallelStream (uber#437) Add empty resource rule if using resource union. (uber#438) Publich v0.20.7 Move okbuck task to its own gradle task class. (uber#436) Use try-with-resources (uber#432) Update README.md Do not allow okbuck to be run without okbuck.wrapper set to true. (uber#433) Set descriptions in tasks class instead of when creating them. (uber#431) Move cleaning the .okbuck/gen folder to the first step of setupOkbuck. (uber#430) Publish v0.20.6 Add support for downloading 22-25 API robolectric runtime dependencies. (uber#427) Skip okbuck if we just want to kill the buck daemon. (uber#425)
cwoodwar6
pushed a commit
to cwoodwar6/okbuck
that referenced
this pull request
Jun 27, 2017
* uber/master: Setup Kotlin home whenever the kotlin gradle plugin is on the classpath. (uber#464) Update several dependencies to latest (uber#462) Remove kotlin-dev repo as 1.1.3 is now released Add support for mixed kotlin and java in regular kotlin modules. (uber#461) Publish v0.22.1 Fix rule type propagation Publish v0.22.0 Update kotlin, gradle and buck versions (uber#460) Add kotlin android integration test and fixup source detection (uber#459) Kotlin Android Support (uber#458) Use more abstractions (uber#457) Prefer abstractions over implementations for upcoming kotlin refactors (uber#456) Add option to exclude some resources from aapt (uber#455) Bump to gradle 4.0 stable. (uber#454) Publish v0.21.0 Migrate to kotlin in memory compiler support in buck (uber#450) Change how dependencies are resolved in preparation for Andrioid Gradle Plugin 3.x (uber#451) Switch the ordering of build config fields. (uber#449) Publish v0.20.10 Revert "Add empty resource rule if using resource union. (uber#438)"
cwoodwar6
pushed a commit
to cwoodwar6/okbuck
that referenced
this pull request
Jul 27, 2017
* upstream/master: Publish v0.21.0 Migrate to kotlin in memory compiler support in buck (uber#450) Change how dependencies are resolved in preparation for Andrioid Gradle Plugin 3.x (uber#451) Switch the ordering of build config fields. (uber#449) Publish v0.20.10 Revert "Add empty resource rule if using resource union. (uber#438)"
cwoodwar6
pushed a commit
to cwoodwar6/okbuck
that referenced
this pull request
Jul 27, 2017
…o master * commit '59bc6fbe8b69da8ca16adbc600928eeafab69ed1': Publish v0.21.0 Migrate to kotlin in memory compiler support in buck (uber#450) Change how dependencies are resolved in preparation for Andrioid Gradle Plugin 3.x (uber#451) Switch the ordering of build config fields. (uber#449) Publish v0.20.10 Revert "Add empty resource rule if using resource union. (uber#438)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that an R file is created for that module even if there are
no resources. Gradle always generates an R file for each module even if
there are no resources.