Use try-with-resources #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kageiit
suggested changes
Apr 26, 2017
runningcode
force-pushed
the
no/try-with-resources
branch
from
8f04b59 to
7f43b0a
Compare
|
Not sure why the wrapper changed, thanks for catching that. |
|
Seems like travis ci is broken. Can you check the failures? |
runningcode
force-pushed
the
no/try-with-resources
branch
3 times, most recently
from
2ea6cdc to
43b46b2
Compare
runningcode
force-pushed
the
no/try-with-resources
branch
from
43b46b2 to
becff1c
Compare
|
Ok! CI passes! :) |
kageiit
suggested changes
May 2, 2017
| TemplateReader replacingReader = new TemplateReader(reader, new TemplateMapResolver(templates)); | ||
|
|
||
| OutputStream outputStream = new FileOutputStream(destination); | ||
| destination.getParentFile().mkdirs(); |
There was a problem hiding this comment.
Can we move the directory creation inside the try?
There was a problem hiding this comment.
Same thing here new FileOutputStream(destination) depends on this file having been created.
| InputStream inputStream = FileUtil.class.getResourceAsStream(resource); | ||
| destination.getParentFile().mkdirs(); | ||
| OutputStream outputStream = new FileOutputStream(destination); | ||
| destination.getParentFile().mkdirs(); |
There was a problem hiding this comment.
Can we move the directory creation inside the try?
There was a problem hiding this comment.
Actually, it can't. This was why this PR was originally failing on ci. The next line, new FileOutputStream(destination) depends on this file having been created.
Luckily, this method doesn't throw an IOException.
kageiit
approved these changes
May 2, 2017
cwoodwar6
pushed a commit
to cwoodwar6/okbuck
that referenced
this pull request
May 10, 2017
* uber/master: Use stream instead of parallelStream (uber#437) Add empty resource rule if using resource union. (uber#438) Publich v0.20.7 Move okbuck task to its own gradle task class. (uber#436) Use try-with-resources (uber#432) Update README.md Do not allow okbuck to be run without okbuck.wrapper set to true. (uber#433) Set descriptions in tasks class instead of when creating them. (uber#431) Move cleaning the .okbuck/gen folder to the first step of setupOkbuck. (uber#430) Publish v0.20.6 Add support for downloading 22-25 API robolectric runtime dependencies. (uber#427) Skip okbuck if we just want to kill the buck daemon. (uber#425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.